elastic/integrationsPublic

NotificationsYou must be signed in to change notification settings
Fork545
Star318

[AWS] Migrate SNS dashboard to lenses#5642

Merged

gpop63 merged 4 commits intoelastic:mainfrom

gpop63:aws-sns-migrate-to-lenses

May 26, 2023

Merged

[AWS] Migrate SNS dashboard to lenses#5642
gpop63 merged 4 commits intoelastic:mainfrom
gpop63:aws-sns-migrate-to-lenses

Conversation

Copy link

Contributor

gpop63 commentedMar 22, 2023

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:

After:

Checklist

I have reviewedtips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package'schangelog.yml file.
I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

gpop63 added2 commits

March 22, 2023 20:43

add lenses and input control group

6c35a30

bump package version

1de159e

gpop63 added Team:Cloud-Monitoring

Label for the Cloud Monitoring team

Integration:awsAWS labels

Mar 22, 2023

Copy link

elasticmachine commentedMar 22, 2023•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-05-26T11:54:52.226+0000
Duration: 51 min 10 sec

Test stats 🧪

Test	Results
Failed	0
Passed	188
Skipped	4
Total	192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

Copy link

elasticmachine commentedMar 22, 2023•
edited
Loading

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`15/15`)	💚
Files	93.75% (`15/16`)	❕
Classes	93.75% (`15/16`)	❕
Methods	86.131% (`236/274`)	❕
Lines	85.925% (`7387/8597`)	❕
Conditionals	100.0% (`0/0`)	💚

gpop63 marked this pull request as ready for review

March 22, 2023 19:48

gpop63 requested review froma team ascode owners

March 22, 2023 19:48

drewdaemon approved these changes

Apr 5, 2023

View reviewed changes

Copy link

Contributor

drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Copy link

botelasticbot commentedMay 5, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue asStale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough:+1. Thank you for your contribution!