Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AWS] Change Kinesis integration documentation to Kinesis Data Stream#4794

Merged
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:kinesis_data_stream
Dec 12, 2022
Merged

[AWS] Change Kinesis integration documentation to Kinesis Data Stream#4794
kaiyan-sheng merged 2 commits intoelastic:mainfrom
kaiyan-sheng:kinesis_data_stream

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-shengkaiyan-sheng commentedDec 8, 2022•
edited
Loading

What does this PR do?

This PR is to adjust Kinesis integration documentation to specify that this integration is to collect metrics for Kinesis Data Streams from CloudWatch.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Related issues

Screenshots

Screen Shot 2022-12-08 at 12 45 18 PM

@kaiyan-shengkaiyan-sheng requested a review froma team as acode ownerDecember 8, 2022 19:49
@kaiyan-shengkaiyan-sheng self-assigned thisDec 8, 2022
@kaiyan-shengkaiyan-sheng added the Team:Cloud-MonitoringLabel for the Cloud Monitoring team labelDec 8, 2022
@elasticmachine
Copy link

elasticmachine commentedDec 8, 2022•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2022-12-08T19:49:31.549+0000

  • Duration: 39 min 54 sec

Test stats 🧪

TestResults
Failed0
Passed177
Skipped3
Total180

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (14/14)💚
Files93.333% (14/15)👎 -6.667
Classes93.333% (14/15)👎 -6.667
Methods85.156% (218/256)👎 -1.51
Lines96.018% (5908/6153)👍 41.881
Conditionals100.0% (0/0)💚

Copy link
Contributor

@zmoogzmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah, the Kinesis family is getting bigger, and using the more precise name helps the user to know what they get with this integration.

LGTM!

kaiyan-sheng reacted with thumbs up emoji
@kaiyan-shengkaiyan-sheng merged commit0f4476a intoelastic:mainDec 12, 2022
@kaiyan-shengkaiyan-sheng deleted the kinesis_data_stream branchDecember 12, 2022 15:59
@kaiyan-sheng
Copy link
ContributorAuthor

@zmoog Yes exactly! We might have to consider at some point to rename the integration to kinesis data stream. But that would be a breaking change. As of right now, updating the documentation is step 1 to clarify what we are collecting with this specific integration. We will do the actual breaking change (if we decide that's necessary) as step 2 later.

zmoog reacted with thumbs up emoji

@elasticmachine
Copy link

Package aws - 1.28.1 containing this change is available athttps://epr.elastic.co/search?package=aws

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zmoogzmoogzmoog approved these changes

Assignees

@kaiyan-shengkaiyan-sheng

Labels

Team:Cloud-MonitoringLabel for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaiyan-sheng@elasticmachine@zmoog

Comments

[8]ページ先頭
©2009-2026 Movatter.jp