Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AWS] Fix EC2 dashboard#4057

Merged
kaiyan-sheng merged 4 commits intoelastic:mainfrom
kaiyan-sheng:ec2_dashboard
Aug 25, 2022
Merged

[AWS] Fix EC2 dashboard#4057
kaiyan-sheng merged 4 commits intoelastic:mainfrom
kaiyan-sheng:ec2_dashboard

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-shengkaiyan-sheng commentedAug 23, 2022•
edited
Loading

What does this PR do?

This PR is to fix EC2 OOTB dashboard:

Screen Shot 2022-08-23 at 4 09 30 PM

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Related issues

@kaiyan-shengkaiyan-sheng requested review froma team ascode ownersAugust 23, 2022 22:19
@kaiyan-shengkaiyan-sheng self-assigned thisAug 23, 2022
@kaiyan-shengkaiyan-sheng added Integration:awsAWS Team:Cloud-MonitoringLabel for the Cloud Monitoring team labelsAug 23, 2022
@elasticmachine
Copy link

elasticmachine commentedAug 23, 2022•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2022-08-25T14:15:47.304+0000

  • Duration: 39 min 20 sec

Test stats 🧪

TestResults
Failed0
Passed162
Skipped2
Total164

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedAug 23, 2022•
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (13/13)💚
Files92.857% (13/14)👎 -4.334
Classes92.857% (13/14)👎 -4.334
Methods84.232% (203/241)👎 -5.162
Lines95.697% (5204/5438)👍 4.77
Conditionals100.0% (0/0)💚

Copy link
Contributor

@drewdaemondrewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

These changes look good to me.

At least some of the old field names appear to also be valid. For example, I see you changedaws.ec2.diskio.write.bytes tohost.disk.write.bytes, but the old field appears to exist (no error here):

Screen Shot 2022-08-24 at 9 51 37 AM

So, I'm assuming you had other reasons for changing the fields?

@kaiyan-sheng
Copy link
ContributorAuthor

So, I'm assuming you had other reasons for changing the fields?

Yep we switched the fields to the new ECS fields as a part of the inventory schema initiative:elastic/beats#19757

drewdaemon reacted with thumbs up emoji

@kaiyan-shengkaiyan-sheng merged commitd26644c intoelastic:mainAug 25, 2022
@kaiyan-shengkaiyan-sheng deleted the ec2_dashboard branchAugust 25, 2022 14:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@drewdaemondrewdaemondrewdaemon approved these changes

+1 more reviewer

@paolafrancescapaolafrancescapaolafrancesca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kaiyan-shengkaiyan-sheng

Labels

Integration:awsAWSTeam:Cloud-MonitoringLabel for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaiyan-sheng@elasticmachine@paolafrancesca@drewdaemon

Comments

[8]ページ先頭
©2009-2026 Movatter.jp