elastic/integrationsPublic

NotificationsYou must be signed in to change notification settings
Fork545
Star318

Comments

Add correct mapping for event.created#3579

Merged

leehinman merged 1 commit intoelastic:mainfrom

leehinman:event_created_fix

Jun 24, 2022

Merged

Add correct mapping for event.created#3579
leehinman merged 1 commit intoelastic:mainfrom
leehinman:event_created_fix

Conversation

Copy link

Contributor

leehinman commentedJun 24, 2022•
edited
Loading

What does this PR do?

data_streams that could use httpjson as an input need a field mapping for event.created because httpjson creates that field.

apache: error
atlassian_bitbucket: audit
carbon_black_cloud: alert, asset_vulnerability_summary, audit,
endpoint_event, watchlist_hit
github: audit
httpjson: generic
snyk: audit, vulnerabilities
winlog: winlog

Checklist

I have reviewedtips for building integrations and this pull request is aligned with them.
~~- [ ] I have verified that all data streams collect metrics or logs.~~
I have added an entry to my package'schangelog.yml file.
~~- [ ] I have verified that Kibana version constraints are current according toguidelines.~~

Related issues

ClosesNo mapping for event.created #3577

Add correct mapping for event.created

3921797

data_streams that could use httpjson as an input need a field mappingfor event.created because httpjson creates that field.- apache: error- atlassian_bitbucket: audit- carbon_black_cloud: alert, asset_vulnerability_summary, audit,  endpoint_event, watchlist_hit- github: audit- httpjson: generic- snyk: audit, vulnerabilities- winlog: winlogCloseselastic#3577

leehinman force-pushed theevent_created_fix branch froma5d1808 to3921797Compare

June 24, 2022 00:58

leehinman added bug

Something isn't working, use only for issues

Team:Security-External Integrations labels

Jun 24, 2022

leehinman marked this pull request as ready for review

June 24, 2022 01:00

leehinman requested review froma team ascode owners

June 24, 2022 01:00

Copy link

elasticmachine commentedJun 24, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link

elasticmachine commentedJun 24, 2022•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-06-24T00:58:57.338+0000
Duration: 17 min 12 sec

Test stats 🧪

Test	Results
Failed	0
Passed	188
Skipped	0
Total	188

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

efd6 approved these changes

Jun 24, 2022

View reviewed changes

Copy link

elasticmachine commentedJun 24, 2022

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`11/11`)	💚
Files	84.615% (`11/13`)	👎 -11.92
Classes	84.615% (`11/13`)	👎 -11.92
Methods	90.196% (`138/153`)	👍 1.341
Lines	91.893% (`2063/2245`)	👍 0.941
Conditionals	100.0% (`0/0`)	💚

muthu-mps reviewed

Jun 24, 2022

View reviewed changes

Copy link

Contributor

muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

When looking into the httpjson field mapping the following fields appears in the sample_events and missing in the mapping [event.ingested, event.agent_id_status, message]. We may need to take this as a separate issue.