Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[AWS] Add Redshift Integration#3569

Merged
girodav merged 6 commits intoelastic:mainfrom
girodav:add_redshift
Jun 27, 2022
Merged

[AWS] Add Redshift Integration#3569
girodav merged 6 commits intoelastic:mainfrom
girodav:add_redshift

Conversation

@girodav
Copy link
Contributor

@girodavgirodav commentedJun 23, 2022•
edited
Loading

What does this PR do?

This PR adds a new datastream forAmazon Redshift metrics.

  • Add new datastream to collect Redshift metrics through Cloudwatch
  • Add system tests
  • Bump AWS package version and change changelog accordingly
  • Add dashboard and screenshots

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

How to test this PR locally

elastic-package test system --data-streams redshift

Related issues

Screenshots

Screenshot 2022-06-23 at 09 28 50

metricbeat-aws-redshift-overview

Screenshot 2022-06-27 at 16 43 57

- Add new datastream to collect Redshift metrics through Cloudwatch- Add system tests- Bump AWS package version and change changelog accordingly- Add dashboard and screenshots
@girodavgirodav added enhancementNew feature or request Integration:awsAWS Team:Cloud-MonitoringLabel for the Cloud Monitoring team labelsJun 23, 2022
@elasticmachine
Copy link

elasticmachine commentedJun 23, 2022•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2022-06-27T15:46:29.056+0000

  • Duration: 37 min 47 sec

Test stats 🧪

TestResults
Failed0
Passed332
Skipped0
Total332

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedJun 23, 2022•
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (11/11)💚
Files91.667% (11/12)👎 -4.901
Classes91.667% (11/12)👎 -4.901
Methods82.692% (172/208)👎 -6.221
Lines92.673% (2087/2252)👍 2.717
Conditionals100.0% (0/0)💚

@girodavgirodav marked this pull request as ready for reviewJune 23, 2022 12:54
@girodavgirodav requested review froma team ascode ownersJune 23, 2022 12:54
@ravikesarwani
Copy link

cc:@Udayel Can you review?

@girodav This is great work.
Can you please provide images for "Add integration" screens as well?
I would like to take a quick peek at the integration docs as well.

I am off on vacation for a little bit so please don't wait on me for merge.

girodav reacted with thumbs up emoji

Copy link
Contributor

@kaiyan-shengkaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Good work!

Copy link
Contributor

@zmoogzmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is excellent work@girodav !

I only have a few questions about ECS fields. I'm not 100% how it should work: should we leverage ECS for fields definitions for groups likecloud.*,container.*, andhost.* vs. adding definition in the.yml file in the integration?

Maybe@kaiyan-sheng can give some advice! 😇

@Udayel
Copy link

Looking good. But please change maintenance mode as a number of database connections. Please add network throughput details to the dashboard. Thank you.

girodav reacted with thumbs up emojikaiyan-sheng reacted with heart emoji

@kaiyan-sheng
Copy link
Contributor

@zmoog Good point! I think if there are any fields in agent.yml that belongs to ECS, we should remove them from agent.yml and add them into ecs.yml instead. This way we don't need to duplicate the descriptions of these fields.

girodav and zmoog reacted with thumbs up emoji

@girodav
Copy link
ContributorAuthor

@kaiyan-sheng@zmoog As mentioned to you offline, I addedagents.yml as I honestly thought it was needed as it is defined by other integrations. I 100% agree in using ECS fields only, if possible. I added this change in the latest commit

zmoog and kaiyan-sheng reacted with thumbs up emoji

@girodavgirodav merged commitf49a09d intoelastic:mainJun 27, 2022
@girodavgirodav deleted the add_redshift branchJune 28, 2022 10:07
@cachedout
Copy link
Contributor

@girodav There are a few Redshift clusters that seem to have been created as a part of the automated tests introduced here which were never cleaned up:

https://us-east-1.console.aws.amazon.com/redshiftv2/home?region=us-east-1#clusters

Could you please see if those can be removed? Thanks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zmoogzmoogzmoog approved these changes

@kaiyan-shengkaiyan-shengkaiyan-sheng approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or requestIntegration:awsAWSTeam:Cloud-MonitoringLabel for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Amazon Redshift metrics integration

7 participants

@girodav@elasticmachine@ravikesarwani@Udayel@kaiyan-sheng@cachedout@zmoog

Comments

[8]ページ先頭
©2009-2026 Movatter.jp