- Notifications
You must be signed in to change notification settings - Fork545
[aws] Fix http.response.status_code to accept 000#3285
Merged
kaiyan-sheng merged 3 commits intoelastic:mainfromMay 9, 2022
kaiyan-sheng:cloudfront_logs
Merged
[aws] Fix http.response.status_code to accept 000#3285kaiyan-sheng merged 3 commits intoelastic:mainfromkaiyan-sheng:cloudfront_logs
kaiyan-sheng merged 3 commits intoelastic:mainfrom
kaiyan-sheng:cloudfront_logs
Conversation
elasticmachine commentedMay 5, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
elasticmachine commentedMay 5, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🌐 Coverage report
|
packages/aws/data_stream/cloudfront_logs/_dev/test/pipeline/test-cloudfront.log-expected.json OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
andrewkroh approved these changesMay 5, 2022
zmoog approved these changesMay 9, 2022
Contributor
zmoog left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
What does this PR do?
Based onAWS docs, in
cloudfrontlogs,sc-statusfield allows000to be one of the acceptable values. With this, we need to change the grok pattern we have when parsing to accept not only positive integers but also just integers.Checklist
changelog.ymlfile.