Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[aws] Fix http.response.status_code to accept 000#3285

Merged
kaiyan-sheng merged 3 commits intoelastic:mainfrom
kaiyan-sheng:cloudfront_logs
May 9, 2022
Merged

[aws] Fix http.response.status_code to accept 000#3285
kaiyan-sheng merged 3 commits intoelastic:mainfrom
kaiyan-sheng:cloudfront_logs

Conversation

@kaiyan-sheng
Copy link
Contributor

@kaiyan-shengkaiyan-sheng commentedMay 5, 2022
edited
Loading

What does this PR do?

Based onAWS docs, incloudfront logs,sc-status field allows000 to be one of the acceptable values. With this, we need to change the grok pattern we have when parsing to accept not only positive integers but also just integers.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

@kaiyan-shengkaiyan-sheng requested a review froma team as acode ownerMay 5, 2022 16:38
@kaiyan-shengkaiyan-sheng self-assigned thisMay 5, 2022
@kaiyan-shengkaiyan-sheng added the Team:Cloud-MonitoringLabel for the Cloud Monitoring team labelMay 5, 2022
@elasticmachine
Copy link

elasticmachine commentedMay 5, 2022
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2022-05-05T20:00:11.288+0000

  • Duration: 28 min 20 sec

Test stats 🧪

TestResults
Failed0
Passed328
Skipped0
Total328

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commentedMay 5, 2022
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (11/11)💚
Files91.667% (11/12)👎 -4.684
Classes91.667% (11/12)👎 -4.684
Methods82.439% (169/205)👎 -5.67
Lines92.673% (2087/2252)👍 3.873
Conditionals100.0% (0/0)💚

Copy link
Contributor

@zmoogzmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@kaiyan-shengkaiyan-sheng merged commit6e093be intoelastic:mainMay 9, 2022
@kaiyan-shengkaiyan-sheng deleted the cloudfront_logs branchMay 9, 2022 17:14
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zmoogzmoogzmoog approved these changes

@andrewkrohandrewkrohandrewkroh approved these changes

Assignees

@kaiyan-shengkaiyan-sheng

Labels

Integration:awsAWSTeam:Cloud-MonitoringLabel for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaiyan-sheng@elasticmachine@zmoog@andrewkroh

Comments


[8]ページ先頭

©2009-2026 Movatter.jp