Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

[apache_spark][node] Change naming convention of the node data stream#3070

Merged
mtojek merged 7 commits intoelastic:mainfrom
yug-rajani:package_apache_spark_nodes_refactor
May 9, 2022
Merged

[apache_spark][node] Change naming convention of the node data stream#3070
mtojek merged 7 commits intoelastic:mainfrom
yug-rajani:package_apache_spark_nodes_refactor

Conversation

@yug-rajani
Copy link
Contributor

@yug-rajaniyug-rajani commentedApr 12, 2022•
edited
Loading

What does this PR do?

  • Refactor thenodes data stream to adjust its name to singular (node) as per the discussionhere.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.yml file to point to the latest Elastic stack release (e.g.^7.13.0).

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/apache_spark directory.
  • Run the following command to run tests.

elastic-package test

@yug-rajaniyug-rajani requested a review froma team as acode ownerApril 12, 2022 05:06
@yug-rajaniyug-rajani changed the titleChange naming convention of node datastream[apache_spark][node] Change naming convention of the node data streamApr 12, 2022
@yug-rajaniyug-rajani self-assigned thisApr 12, 2022
@yug-rajaniyug-rajani added enhancementNew feature or request Team:IntegrationsLabel for the Integrations team labelsApr 12, 2022
@elasticmachine
Copy link

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link

elasticmachine commentedApr 12, 2022•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2022-05-03T09:15:11.568+0000

  • Duration: 17 min 26 sec

Test stats 🧪

TestResults
Failed0
Passed12
Skipped0
Total12

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One more thing. When you push updates to an already published package, please raise the manifest version :)

yug-rajani reacted with thumbs up emoji
@mtojekmtojek self-requested a reviewApril 12, 2022 07:42
Copy link
Contributor

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

requested changes

@yug-rajaniyug-rajani requested a review frommtojekApril 12, 2022 09:28
@yug-rajaniyug-rajani linked an issueApr 26, 2022 that may beclosed by this pull request
16 tasks
Copy link
Member

@jsorianojsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

yug-rajani reacted with thumbs up emoji
@elasticmachine
Copy link

elasticmachine commentedApr 28, 2022•
edited
Loading

🌐 Coverage report

NameMetrics % (covered/total)Diff
Packages100.0% (0/0)💚
Files100.0% (0/0)💚 3.275
Classes100.0% (0/0)💚 3.275
Methods75.0% (12/16)👎 -14.113
Lines100.0% (0/0)💚 10.01
Conditionals100.0% (0/0)💚

@mtojekmtojek merged commit3323466 intoelastic:mainMay 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jsorianojsorianojsoriano approved these changes

@ruflinruflinruflin approved these changes

@mtojekmtojekAwaiting requested review from mtojek

Assignees

@yug-rajaniyug-rajani

Labels

enhancementNew feature or requestIntegration:apache_sparkApache SparkTeam:IntegrationsLabel for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create Apache Spark integration

6 participants

@yug-rajani@elasticmachine@jsoriano@ruflin@mtojek@masci
[8]ページ先頭
©2009-2026 Movatter.jp