Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

AWS Network Firewall integration#2199

Merged
taylor-swanson merged 19 commits intoelastic:masterfrom
taylor-swanson:aws-firewall
Dec 13, 2021
Merged

AWS Network Firewall integration#2199
taylor-swanson merged 19 commits intoelastic:masterfrom
taylor-swanson:aws-firewall

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swansontaylor-swanson commentedNov 19, 2021•
edited
Loading

What does this PR do?

This PR adds a new integration for AWS Network Firewall.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.yml file to point to the latest Elastic stack release (e.g.^7.13.0).

How to test this PR locally

cd packages/awselastic-package test pipeline

Related issues

Relates#1204

Screenshots

aws-firewall

filebeat-aws-firewall-overview
filebeat-aws-firewall-alerts
filebeat-aws-firewall-flows
metricbeat-aws-firewall-overview

- Add integration for AWS Network Firewall
@elasticmachine
Copy link

elasticmachine commentedNov 19, 2021•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreviewpreview

Expand to view the summary

Build stats

  • Start Time: 2021-12-13T19:38:19.718+0000

  • Duration: 27 min 1 sec

  • Commit:6d7ba48

Test stats 🧪

TestResults
Failed0
Passed315
Skipped0
Total315

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@taylor-swansontaylor-swanson marked this pull request as ready for reviewNovember 29, 2021 16:09
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

@andrewkrohandrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice dashboards

jamiehynds reacted with thumbs up emoji
@andrewkrohandrewkroh requested a review froma teamNovember 30, 2021 00:57
@andrewkroh
Copy link
Member

We should get the integrations team to review as well since they own the package.

@jamiehyndsjamiehynds added New IntegrationIssue or pull request for creating a new integration package. Integration:awsAWS labelsDec 8, 2021
@kaiyan-sheng
Copy link
Contributor

Hi@taylor-swanson , this looks great!! One small thing: on the dashboard, could you edit the visualization title so[Logs AWS] and[Metrics AWS] don't show?[Logs AWS] and[Metrics AWS] should still be a part of the visualization title but just not displayed on the dashboard. Thanks!

@taylor-swanson
Copy link
ContributorAuthor

Hi@taylor-swanson , this looks great!! One small thing: on the dashboard, could you edit the visualization title so[Logs AWS] and[Metrics AWS] don't show?[Logs AWS] and[Metrics AWS] should still be a part of the visualization title but just not displayed on the dashboard. Thanks!

I can certainly do that!

kaiyan-sheng reacted with thumbs up emojikaiyan-sheng reacted with heart emoji

@taylor-swanson
Copy link
ContributorAuthor

The visualizations have been updated to not include[Logs AWS] or[Metrics AWS] (on the dashboard itself). I also split the custom action packets from the rest of the packet metrics. If a customer didn't set up custom actions, this actually broke the graph (one of the vertical axes was missing).

Screen Shot 2021-12-09 at 10 02 20 AM

I can also collect new/updated screenshots, but I may hold off on that until any other issues are addressed. It's a bit cumbersome to get data to show up on the dashboards as I have to push live traffic through AWS.

Copy link
Contributor

@kaiyan-shengkaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me!

@taylor-swansontaylor-swanson merged commit9cba81e intoelastic:masterDec 13, 2021
@taylor-swansontaylor-swanson deleted the aws-firewall branchDecember 14, 2021 14:23
@jamiehynds
Copy link

@kaiyan-sheng anything stopping us from pushing this integration to production, or is there a need to wait until the next stack release?

@kaiyan-sheng
Copy link
Contributor

@jamiehynds Nothing is stopping us from pushing this to production 🙂 We just haven't done a package promotion in a while for AWS. Let me run the promote command right now.

@jamiehynds
Copy link

Thanks@kaiyan-sheng! On a related note, I created this issue to discuss automation of package promotion if you want to chime in:elastic/elastic-package#642

Once AWS Network Firewall is promoted, I'll get it added to the integrations page on the website and on the docs site too.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@andrewkrohandrewkrohandrewkroh approved these changes

@kaiyan-shengkaiyan-shengkaiyan-sheng approved these changes

+1 more reviewer

@legoguy1000legoguy1000legoguy1000 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementNew feature or requestIntegration:awsAWSNew IntegrationIssue or pull request for creating a new integration package.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@taylor-swanson@elasticmachine@andrewkroh@kaiyan-sheng@jamiehynds@legoguy1000

Comments

[8]ページ先頭
©2009-2026 Movatter.jp