elastic/integrationsPublic

NotificationsYou must be signed in to change notification settings
Fork545
Star318

aws: changes for unified integration UI#2003

Merged

endorama merged 23 commits intoelastic:masterfrom

endorama:uniform-ui/aws

Oct 28, 2021

Merged

aws: changes for unified integration UI#2003
endorama merged 23 commits intoelastic:masterfrom
endorama:uniform-ui/aws

Conversation

Copy link

Contributor

endorama commentedOct 21, 2021

What does this PR do?

Align package title and description for improved Unified Integration UI display.

Checklist

~~I have reviewedtips for building integrations and this pull request is aligned with them.~~
~~I have verified that all data streams collect metrics or logs.~~
I have added an entry to my package'schangelog.yml file.
If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.yml file to point to the latest Elastic stack release (e.g.^7.13.0).

Author's Checklist

promote package to staging
promote package to production

How to test this PR locally

Related issues

Part ofUpdate title and description based on guidelines for Elastic Agent based Observability integrations #1901

Screenshots

endorama added the Team:IntegrationsLabel for the Integrations team label

Oct 21, 2021

endorama self-assigned this

Oct 21, 2021

endorama requested a review fromakshay-saraswat

October 21, 2021 09:11

Copy link

elasticmachine commentedOct 21, 2021

Pinging @elastic/integrations (Team:Integrations)

endorama changed the title~~auditd: changes for unified integration UI~~aws: changes for unified integration UI

Oct 21, 2021

Copy link

elasticmachine commentedOct 21, 2021•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-10-28T14:14:48.994+0000
Duration: 28 min 43 sec
Commit:295765b

Test stats 🧪

Test	Results
Failed	0
Passed	260
Skipped	0
Total	260

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

endorama mentioned this pull request

Oct 21, 2021

Update title and description based on guidelines for Elastic Agent based Observability integrations#1901

Closed

paolafrancesca approved these changes

Oct 21, 2021

View reviewed changes

akshay-saraswat reviewed

Oct 21, 2021

View reviewed changes

packages/aws/data_stream/cloudtrail/manifest.yml OutdatedShow resolvedHide resolved

akshay-saraswat reviewed

Oct 22, 2021

View reviewed changes

packages/aws/manifest.yml Outdated

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we replace "from the" with "from" wherever it was provided in the description? Received a review on my spreadsheet that the inconsistency of "the" looks odd.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

done

endorama added20 commits

October 25, 2021 10:48

aws: update description

2826e2d

aws: bump to 1.3.2

762e48a

update PR link in changelog

5e798ee

aws: update billing

4f24ad4

aws update cloudtrail

6628824

aws: update cloudwatch

a22c452

aws: update dynamodb

518731f

aws: update ebs

a4bdff8

aws: update ec2

9c7d18c

aws: update elb

f614051

aws: update lambda

47c7cb9

aws: update natgateway

7e1869f

aws: update rds

de91493

aws: update s3

c61b3b9

aws: update sns

001bbe1

aws: update sqs

706f44a

aws: update transitgateway

80bee1a

aws: update usage

bce47e3

aws: update vpcflow

2f9cd58

aws: update vpn

b1fd18f

akshay-saraswat approved these changes

Oct 26, 2021

View reviewed changes

kaiyan-sheng approved these changes

Oct 27, 2021

View reviewed changes

kaiyan-sheng reviewed

Oct 27, 2021

View reviewed changes

Copy link

Contributor

kaiyan-sheng left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@endorama @akshay-saraswat I would suggest keepingCloudTrail, instead of changing it toCloudtrail. Because in AWS, CloudTrail is the actual service name. For example:https://aws.amazon.com/cloudtrail/
WDYT?

Copy link

akshay-saraswat commentedOct 27, 2021

@endorama @akshay-saraswat I would suggest keepingCloudTrail, instead of changing it toCloudtrail. Because in AWS, CloudTrail is the actual service name. For example:https://aws.amazon.com/cloudtrail/ WDYT?

I agree with you. That's my mistake. I did not consider the AWS naming convention while creating the spreadsheet.@endorama please replaceCloudtrail withCloudTrail in both title and description. Thanks!