- Notifications
You must be signed in to change notification settings - Fork545
Comments
[IIS] Fix access log parsing on newer IIS 10 versions#17461
Open
Alphayeeeet wants to merge 3 commits intoelastic:mainfrom
Open
[IIS] Fix access log parsing on newer IIS 10 versions#17461Alphayeeeet wants to merge 3 commits intoelastic:mainfrom
Alphayeeeet wants to merge 3 commits intoelastic:mainfrom
Conversation
ReviewersBuildkite won't run for external contributors automatically; you need to add a comment:
NOTE:https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details. |
ContributorAuthor
Alphayeeeet commentedFeb 19, 2026
@team Please run CI and approve if applicable. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Integration:iisIIS Team:Obs-InfraObsObservability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please label as bugfix
Proposed commit message
Fix access log parsing on newer IIS 10 versions
During newest IIS updates, the access log parsing was broken and response bytes have been falsely inserted into the event duration field.
This PR introduces a new grok pattern in the access log parsing ingest pipeline, to support the changed log format that IIS introduced.
For reference:
Our broken IIS instances are Version 10.0.17763.1 (and probably any newer too).
As the log format changed silently, we didn't find the issue in the integration very easily. However after huge response times were shown in our dashboards, we debugged and found that another grok pattern falsely matched, and therefore values were parsed into wrong fields.
This PR fixes exactly this issue and introduced a new testcase line, to prevent any future breaking of this.