- Notifications
You must be signed in to change notification settings - Fork545
Comments
Add kafka_input_otel package for Kafka receiver#17438
Conversation
Create new OpenTelemetry input package for consuming telemetry data(logs, metrics, traces) from Kafka using the Kafka receiver.Key features:- Multi-signal support with dynamic_signal_types: true- Signal-specific topics and encoding configuration- SASL, Kerberos, and TLS authentication options- Consumer settings (offset, session timeout, heartbeat)- Metadata and auto-commit configuration- Header extraction support- Telemetry and error backoff configurationRequires Kibana ^9.4.0 and format_version 3.6.0 for multi-signal support.Closes#17139Co-authored-by: Mario Rodriguez Molins <mrodm@users.noreply.github.com>
github-actionsbot commentedFeb 17, 2026 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against theElastic Docs style guide. To use Vale locally or report issues, refer toElastic style guide for Vale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The template has a structural issue where SASL and Kerberos authentication blocks could both generate separateauth: YAML keys, creating invalid YAML. See inline comment for the fix.
Why is Claude responding? | Type@claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The duplicateauth: block issue (SASL vs Kerberos generating separate YAML keys) identified in the prior review remains the blocking issue. Once fixed using{{else if kerberos_service_name}}, the package should be ready.
Consider adding policy tests for SASL and Kerberos authentication branches once the template is fixed, to catch this class of issue in the future.
Why is Claude responding? | Type@claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The duplicateauth: block issue identified in prior reviews (SASL vs Kerberos generating separate YAML keys) still needs to be fixed before this can be approved. No additional issues found.
Why is Claude responding? | Type@claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Ensure that auth.sasl and auth.kerberos are not set at the same time.Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The authentication template logic at lines 96-167 ininput.yml.hbs is still broken. The attempted fix from prior reviews created a new problem: whenkerberos_service_name is set withoutsasl_mechanism, both the kerberos block at lines 127-146 AND the duplicate kerberos block at lines 148-166 are output, creating invalid YAML with duplicatekerberos: keys.
The entire auth section (lines 96-167) needs to be replaced with the single, clean if/else-if structure provided in the inline comment.
Why is Claude responding? | Type@claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
Uh oh!
There was an error while loading.Please reload this page.
Removed redundant SASL and Kerberos authentication options to streamline the configuration process. Ensured that only relevant authentication settings are retained for clarity and maintainability.
Streamlined the Kerberos authentication configuration by removing redundant checks and ensuring that the keytab file is only referenced when the keytab option is enabled. This improves clarity and maintainability of the authentication settings.
elasticmachine commentedFeb 17, 2026
💚 Build Succeeded
History
cc@mrodm |
mrodm commentedFeb 17, 2026
Working on adding system tests to validate that it works as expected. |
Uh oh!
There was an error while loading.Please reload this page.
Proposed commit message
Create new OpenTelemetry input package for consuming telemetry data (logs, metrics, traces) from Kafka using the Kafka receiver.
Key features:
dynamic_signal_types: trueChecklist
changelog.ymlfile.I have verified that any added dashboard complies with Kibana'sDashboard good practicesAuthor's Checklist
How to test this PR locally
Related issues
Screenshots
Generated withClaude Code
Logo generated also with the assistance of Cursor.