Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove duplicate security solution tags from AWS package#17022

Merged
teresaromero merged 10 commits intoelastic:mainfrom
teresaromero:fix-duplicate-tags-aws
Feb 11, 2026
Merged

Remove duplicate security solution tags from AWS package#17022
teresaromero merged 10 commits intoelastic:mainfrom
teresaromero:fix-duplicate-tags-aws

Conversation

@teresaromero
Copy link
Contributor

@teresaromeroteresaromero commentedJan 21, 2026•
edited
Loading

Proposed commit message

This PR removes duplicate security-solution-default tags from Kibana dashboards, searches, and visualizations, deletes corresponding tag definition files, and updates changelog entries and manifest versions.

Changes:

  • Removed duplicate tag references from dashboards and searches
  • Deleted duplicate tag definition files
  • Added changelog entries (bugfix, patch version)
  • Updated package manifest versions

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.
  • I have verified that any added dashboard complies with Kibana'sDashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

github-actions[bot] reacted with eyes emoji
Packages affected:This PR removes duplicate security-solution-default tags from Kibanadashboards, searches, and visualizations, deletes corresponding tagdefinition files, and updates changelog entries and manifest versions.Changes:- Removed duplicate tag references from dashboards and searches- Deleted duplicate tag definition files- Added changelog entries (bugfix, patch version)- Updated package manifest versionsTotal files changed: 14
@teresaromeroteresaromero added the bugfixPull request that fixes a bug issue labelJan 21, 2026
@teresaromeroteresaromero marked this pull request as ready for reviewJanuary 21, 2026 15:25
@teresaromeroteresaromero requested review froma team ascode ownersJanuary 21, 2026 15:25
@teresaromeroteresaromero added Team:Obs-InfraObsObservability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service IntegrationsSecurity Service Integrations team [elastic/security-service-integrations] Team:obs-ds-hosted-servicesObservability Hosted Services team [elastic/obs-ds-hosted-services] labelsJan 21, 2026
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@andrewkrohandrewkroh added the dashboardRelates to a Kibana dashboard bug, enhancement, or modification. labelJan 21, 2026
Copy link
Contributor

@efd6efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Confirming my understanding that the canonical location for tags will now be in packages/aws/kibana/tag/aws-security-solution-default.json. Is that correct?

@teresaromero
Copy link
ContributorAuthor

Confirming my understanding that the canonical location for tags will now be in packages/aws/kibana/tag/aws-security-solution-default.json. Is that correct?

When a tag is defined attags.yml, there is no need to export it again. This is a fix that will prevent lint errors when the new validation is released andelastic-package export is fixed so it does not duplicate the tag. When the tag is at the yml file and as json, it appears duplicated at the UI

Copy link
Contributor

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PR correctly removes duplicate security-solution-default tag references from all affected dashboards and searches (9 dashboards, 3 searches), deletes the corresponding tag definition file, updates the changelog, and bumps the version. All files containing the duplicate tag are addressed, and the changes align with the validation requirements from package-spec PR#1042 and elastic-package PR#3163.

Why is Claude responding? | Type@claude to interact further

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

teresaromero reacted with thumbs up emoji
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PR correctly removes duplicate security-solution-default tag references from the AWS package. The changes are valid because:

  1. Thekibana/tags.yml file already defines the Security Solution tag assignments, making the inline JSON references redundant
  2. All modified JSON files maintain valid structure after the tag reference removal
  3. The changelog entry and version bump follow the repository conventions
  4. elastic-package check passes without duplicate tag errors (SVR00007)

The PR aligns with the package-spec validation changes fromelastic/package-spec#1042.

Why is Claude responding? | Type@claude to interact further

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@efd6
Copy link
Contributor

efd6 commentedFeb 2, 2026

When a tag is defined attags.yml, there is no need to export it again.

Thanks for the clarification.

@elasticmachine
Copy link

💚 Build Succeeded

History

@teresaromeroteresaromero merged commit0b246ed intoelastic:mainFeb 11, 2026
9 checks passed
@elastic-vault-github-plugin-prod

Package aws - 6.1.1 containing this change is available athttps://epr.elastic.co/package/aws/6.1.1/

jakubgalecki0 pushed a commit to jakubgalecki0/integrations that referenced this pull requestFeb 19, 2026
* Remove duplicate security solution tags from AWS packagePackages affected:This PR removes duplicate security-solution-default tags from Kibanadashboards, searches, and visualizations, deletes corresponding tagdefinition files, and updates changelog entries and manifest versions.Changes:- Removed duplicate tag references from dashboards and searches- Deleted duplicate tag definition files- Added changelog entries (bugfix, patch version)- Updated package manifest versionsTotal files changed: 14* update changelog* Remove aws-security-solution-default tag to eliminate duplication* Update packages/aws/changelog.ymlCo-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>---------Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@efd6efd6efd6 left review comments

@github-actionsgithub-actions[bot]github-actions[bot] approved these changes

Assignees

No one assigned

Labels

bugfixPull request that fixes a bug issuedashboardRelates to a Kibana dashboard bug, enhancement, or modification.Integration:awsAWSTeam:obs-ds-hosted-servicesObservability Hosted Services team [elastic/obs-ds-hosted-services]Team:Obs-InfraObsObservability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]Team:Security-Service IntegrationsSecurity Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teresaromero@elasticmachine@efd6@andrewkroh

Comments

[8]ページ先頭
©2009-2026 Movatter.jp