- Notifications
You must be signed in to change notification settings - Fork545
Comments
[BugFix] Removescript_block_signature - Performance Problems#15907
Merged
[BugFix] Removescript_block_signature - Performance Problems#15907
script_block_signature - Performance Problems#15907Conversation
elasticmachine commentedNov 9, 2025
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
elasticmachine commentedNov 9, 2025
💚 Build Succeeded
History
cc@w0rk3r |
elasticmachine commentedNov 10, 2025
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
marc-gr approved these changesNov 10, 2025
7f2ab1f intomain 7 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Package windows - 3.2.2 containing this change is available athttps://epr.elastic.co/package/windows/3.2.2/ |
tehbooom pushed a commit to tehbooom/integrations that referenced this pull requestNov 19, 2025
…tic#15907)* [BugFix] Remove `script_block_signature` - Performance Problems* ++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
bugfixPull request that fixes a bug issue documentationImprovements or additions to documentation. Applied to PRs that modify *.md files. Integration:windowsWindows Team:Elastic-Agent-Data-PlaneAgent Data Plane team [elastic/elastic-agent-data-plane] Team:Security-Service IntegrationsSecurity Service Integrations team [elastic/security-service-integrations]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Summary
It seems that the gsub processor I added in#15834 to handle the way PowerShell scripts contain the signature is too expensive and it is causing performance problems.
As I mentioned in#15834, the field was not being populated in my cluster and detection rules telemetry, and will not be populated in most PowerShell scripts as it ends up being split in two different events, so I propose to remove it to solve the problem.
Checklist
changelog.ymlfile.