Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

updating disclaimer for aws_cloudwatch logs#13370

Merged
gizas merged 4 commits intomainfrom
fixcloudwatch
Apr 3, 2025
Merged

updating disclaimer for aws_cloudwatch logs#13370
gizas merged 4 commits intomainfrom
fixcloudwatch

Conversation

@gizas
Copy link
Contributor

@gizasgizas commentedApr 1, 2025
edited
Loading

  • Breaking change

Proposed commit message

Please explain:

  • WHAT: We change the default value of the cloudwatch_lods data_stream.dataset to aws.cloudwatch_logs
  • WHY: This needs to match the package name cloudwatch_logs in order the preinstalled ingest mappings/templates for the given datastream to apply

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.
  • I have verified that any added dashboard complies with Kibana'sDashboard good practices

How to test this PR locally

  • Clone dir
  • cd packages/integrations/kubernetes
  • elastic-package build
  • elastic-package stack up -d -vvv --version=9.0.0-SNAPSHOT
  • Create an elastic-agent policy
  • Add kubernetes integration. The version 2.45.0 should be available

Related issues

Screenshots

This is how the discalimer is displayed:

Screenshot 2025-04-02 at 4 26 19 PM

The default ingest template is displayed below:

Screenshot 2025-04-02 at 4 33 04 PM

So we changed the datastream.dataset toaws.cloudwatch_logs

Successful processing of cloudwatch events:
Screenshot 2025-04-02 at 5 48 48 PM

Important: We enable the preserve_original event that is defined iningest pipeline

This one works fine as you can see in previous image

But we test again with version 2.44.0:

Screenshot 2025-04-02 at 6 02 54 PM

See that event.original is not present and that that preserve_original.event is present that indicates that the option was enabled.

Kavindu-Dodan reacted with hooray emoji
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@andrewkrohandrewkroh changed the titleupdating desclaimer for aws_cloudwatch logsupdating disclaimer for aws_cloudwatch logsApr 1, 2025
Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
@gizasgizas marked this pull request as ready for reviewApril 2, 2025 15:11
@gizasgizas requested review froma team ascode ownersApril 2, 2025 15:11
Copy link
Contributor

@Kavindu-DodanKavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM :)

@andrewkrohandrewkroh added the Team:obs-ds-hosted-servicesObservability Hosted Services team [elastic/obs-ds-hosted-services] labelApr 2, 2025
@elastic-sonarqube
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

@gizasgizas merged commit662bd7e intomainApr 3, 2025
7 checks passed
@gizasgizas deleted the fixcloudwatch branchApril 3, 2025 06:59
@elastic-vault-github-plugin-prod

Package aws - 2.45.0 containing this change is available athttps://epr.elastic.co/package/aws/2.45.0/

flexitrev pushed a commit that referenced this pull requestApr 3, 2025
* updating disclaimer for aws_cloudwatch logsSigned-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>---------Signed-off-by: Andreas Gkizas <andreas.gkizas@elastic.co>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@Kavindu-DodanKavindu-DodanKavindu-Dodan approved these changes

Assignees

No one assigned

Labels

Integration:awsAWSTeam:obs-ds-hosted-servicesObservability Hosted Services team [elastic/obs-ds-hosted-services]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gizas@elasticmachine@Kavindu-Dodan@andrewkroh

Comments


[8]ページ先頭

©2009-2026 Movatter.jp