Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for Splunk authentication tokens to third party REST API#1147

Merged
leehinman merged 3 commits intoelastic:masterfrom
leehinman:apache_splunk_token_auth
Jun 29, 2021
Merged

Add support for Splunk authentication tokens to third party REST API#1147
leehinman merged 3 commits intoelastic:masterfrom
leehinman:apache_splunk_token_auth

Conversation

@leehinman
Copy link
Contributor

@leehinmanleehinman commentedJun 17, 2021•
edited
Loading

What does this PR do?

Adds support for Splunk Authentication tokens to third party
REST API source.

  • apache
  • aws
  • system
  • windows
  • winlog
  • zeek

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
    - [ ] If I'm introducing a new feature, I have modified the Kibana version constraint in my package'smanifest.yml file to point to the latest Elastic stack release (e.g.^7.13.0).

How to test this PR locally

https://docs.splunk.com/Documentation/Splunk/8.2.0/Security/CreateAuthTokens
https://docs.splunk.com/Documentation/Splunk/8.2.0/RESTUM/RESTusing

Need to make tokens then try configuring tokens and ingesting data

Related issues

Screenshots

Screen Shot 2021-06-23 at 14 34 17

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commentedJun 17, 2021•
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline ViewTest ViewChangesArtifactspreview

Expand to view the summary

Build stats

  • Build Cause:Pull request #1147 updated

  • Start Time: 2021-06-29T12:58:20.628+0000

  • Duration: 57 min 6 sec

  • Commit:a9e3ae4

Test stats 🧪

TestResults
Failed0
Passed914
Skipped0
Total914

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In my opinion I would go an even simpler route and only specify in the token that it "Cannot be used with username and password".

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, that's better. If this looks good I'll update all the other third party screens to match.

Copy link
Member

@andrewkrohandrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🚢

@leehinmanleehinman changed the titleAdd support for Splunk authentication tokens to ApacheAdd support for Splunk authentication tokens to third party REST APIJun 25, 2021
@leehinmanleehinmanforce-pushed theapache_splunk_token_auth branch 3 times, most recently from3ad0fa7 toab39923CompareJune 29, 2021 03:24
@leehinmanleehinmanforce-pushed theapache_splunk_token_auth branch fromab39923 toa9e3ae4CompareJune 29, 2021 12:58
@leehinmanleehinman merged commit3543c85 intoelastic:masterJun 29, 2021
@leehinmanleehinman deleted the apache_splunk_token_auth branchSeptember 28, 2021 20:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@andrewkrohandrewkrohandrewkroh approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leehinman@elasticmachine@andrewkroh

Comments

[8]ページ先頭
©2009-2026 Movatter.jp