Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ssi_all: use triple-brace templating in complex templates#11314

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:7641-ssi_all_complex
Oct 3, 2024
Merged

ssi_all: use triple-brace templating in complex templates#11314
efd6 merged 1 commit intoelastic:mainfrom
efd6:7641-ssi_all_complex

Conversation

@efd6
Copy link
Contributor

@efd6efd6 commentedOct 3, 2024

Proposed commit message

This is a second pass at replacing double brace template marks with triple bracemarks. It addresses more complex uses that the sed rewrite did not find by usingPCRE via perl.[git-generate]for f in $((for p in $(yq 'select(.owner.github == "elastic/security-service-integrations")|.name' packages/**/manifest.yml \| grep -v -- '---'); dorg -l -g '*.yml' "[^{]\{\{[^{][ .a-zA-Z0-9_]*[^}]}}[^}]" packages/$pdone)|grep -v "cloudflare"|grep "elasticsearch/ingest_pipeline"|sort|uniq); doperl -pi -e 's/(?<!\{)(\{\{[^{][ .a-zA-Z0-9_]*[^}]}})(?!\})/{$1}/g' $fdonefor p in $(git diff --name-only HEAD~1|cut -d/ -f1,2|sort|uniq); do(cd $pelastic-package test pipeline -gelastic-package changelog add \--description "Use triple-brace Mustache templating when referencing variables in ingest pipelines." \--type bugfix \--next patch \--link https://github.com/elastic/integrations/pull/)>/dev/null 2>&1done

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6efd6 added Integration:AllApplies to all integrations [Integration not found in source] bugfixPull request that fixes a bug issue Team:Security-Service IntegrationsSecurity Service Integrations team [elastic/security-service-integrations] labelsOct 3, 2024
@efd6efd6 self-assigned thisOct 3, 2024
This is a second pass at replacing double brace template marks with triple bracemarks. It addresses more complex uses that the sed rewrite did not find by usingPCRE via perl.[git-generate]for f in $((for p in $(yq 'select(.owner.github == "elastic/security-service-integrations")|.name' packages/**/manifest.yml \| grep -v -- '---'); dorg -l -g '*.yml' "[^{]\{\{[^{][ .a-zA-Z0-9_]*[^}]}}[^}]" packages/$pdone)|grep -v "cloudflare"|grep "elasticsearch/ingest_pipeline"|sort|uniq); doperl -pi -e 's/(?<!\{)(\{\{[^{][ .a-zA-Z0-9_]*[^}]}})(?!\})/{$1}/g' $fdonefor p in $(git diff --name-only HEAD~1|cut -d/ -f1,2|sort|uniq); do(cd $pelastic-package test pipeline -gelastic-package changelog add \--description "Use triple-brace Mustache templating when referencing variables in ingest pipelines." \--type bugfix \--next patch \--linkelastic#11314)>/dev/null 2>&1done
@efd6efd6force-pushed the7641-ssi_all_complex branch from410ae7b toc43a37bCompareOctober 3, 2024 02:33
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

  • 💔Build #16737 failed 410ae7b97b799b72aee5bcd3303c94153af03f82

cc@efd6

@elastic-sonarqube
Copy link

Quality Gate failedQuality Gate failed

Failed conditions
51.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@andrewkrohandrewkroh removed the Integration:AllApplies to all integrations [Integration not found in source] labelOct 3, 2024
@efd6efd6 marked this pull request as ready for reviewOctober 3, 2024 03:06
@efd6efd6 requested a review froma team as acode ownerOctober 3, 2024 03:06
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@andrewkrohandrewkroh added Integration:slackSlack Logs (Community supported) Integration:ti_abusechabuse.ch Integration:atlassian_jiraAtlassian Jira (Community supported) Integration:bitdefenderBitDefender (Community supported) Integration:gigamonGigamon (Partner supported) Integration:mimecastMimecast (Partner supported) Integration:crowdstrikeCrowdStrike Integration:symantec_endpointSymantec Endpoint Protection Integration:akamaiAkamai (Community supported) Integration:sysdigSysdig Integration:falcoFalco Integration:ti_maltiverseMaltiverse (Partner supported) Integration:githubGitHub Integration:zoomZoom Integration:cisa_kevsCISA Known Exploited Vulnerabilities (Community supported) labelsOct 3, 2024
@elastic-vault-github-plugin-prod

Package aws_bedrock - 0.10.1 containing this change is available athttps://epr.elastic.co/search?package=aws_bedrock

@elastic-vault-github-plugin-prod

Package bitdefender - 2.1.3 containing this change is available athttps://epr.elastic.co/search?package=bitdefender

@elastic-vault-github-plugin-prod

Package cisa_kevs - 1.3.1 containing this change is available athttps://epr.elastic.co/search?package=cisa_kevs

@elastic-vault-github-plugin-prod

Package cisco_duo - 2.0.1 containing this change is available athttps://epr.elastic.co/search?package=cisco_duo

@elastic-vault-github-plugin-prod

Package cisco_umbrella - 1.26.2 containing this change is available athttps://epr.elastic.co/search?package=cisco_umbrella

@elastic-vault-github-plugin-prod

Package crowdstrike - 1.42.2 containing this change is available athttps://epr.elastic.co/search?package=crowdstrike

@elastic-vault-github-plugin-prod

Package falco - 1.0.2 containing this change is available athttps://epr.elastic.co/search?package=falco

@elastic-vault-github-plugin-prod

Package forcepoint_web - 1.9.1 containing this change is available athttps://epr.elastic.co/search?package=forcepoint_web

@elastic-vault-github-plugin-prod

Package gigamon - 1.0.1 containing this change is available athttps://epr.elastic.co/search?package=gigamon

@elastic-vault-github-plugin-prod

Package github - 1.29.3 containing this change is available athttps://epr.elastic.co/search?package=github

@elastic-vault-github-plugin-prod

Package keycloak - 1.23.2 containing this change is available athttps://epr.elastic.co/search?package=keycloak

@elastic-vault-github-plugin-prod

Package mimecast - 1.27.2 containing this change is available athttps://epr.elastic.co/search?package=mimecast

@elastic-vault-github-plugin-prod

Package netskope - 1.20.2 containing this change is available athttps://epr.elastic.co/search?package=netskope

@elastic-vault-github-plugin-prod

Package okta - 2.12.2 containing this change is available athttps://epr.elastic.co/search?package=okta

@elastic-vault-github-plugin-prod

Package opencanary - 0.1.3 containing this change is available athttps://epr.elastic.co/search?package=opencanary

@elastic-vault-github-plugin-prod

Package qualys_vmdr - 5.2.1 containing this change is available athttps://epr.elastic.co/search?package=qualys_vmdr

@elastic-vault-github-plugin-prod

Package slack - 1.21.2 containing this change is available athttps://epr.elastic.co/search?package=slack

@elastic-vault-github-plugin-prod

Package symantec_endpoint - 2.16.1 containing this change is available athttps://epr.elastic.co/search?package=symantec_endpoint

@elastic-vault-github-plugin-prod

Package sysdig - 0.1.1 containing this change is available athttps://epr.elastic.co/search?package=sysdig

@elastic-vault-github-plugin-prod

Package thycotic_ss - 1.8.1 containing this change is available athttps://epr.elastic.co/search?package=thycotic_ss

@elastic-vault-github-plugin-prod

Package ti_abusech - 2.3.5 containing this change is available athttps://epr.elastic.co/search?package=ti_abusech

@elastic-vault-github-plugin-prod

Package ti_custom - 0.1.3 containing this change is available athttps://epr.elastic.co/search?package=ti_custom

@elastic-vault-github-plugin-prod

Package ti_cybersixgill - 1.30.5 containing this change is available athttps://epr.elastic.co/search?package=ti_cybersixgill

@elastic-vault-github-plugin-prod

Package ti_maltiverse - 1.2.5 containing this change is available athttps://epr.elastic.co/search?package=ti_maltiverse

@elastic-vault-github-plugin-prod

Package ti_misp - 1.35.5 containing this change is available athttps://epr.elastic.co/search?package=ti_misp

@elastic-vault-github-plugin-prod

Package zoom - 1.20.1 containing this change is available athttps://epr.elastic.co/search?package=zoom

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull requestFeb 4, 2025
)This is a second pass at replacing double brace template marks with triple bracemarks. It addresses more complex uses that the sed rewrite did not find by usingPCRE via perl.[git-generate]for f in $((for p in $(yq 'select(.owner.github == "elastic/security-service-integrations")|.name' packages/**/manifest.yml \| grep -v -- '---'); dorg -l -g '*.yml' "[^{]\{\{[^{][ .a-zA-Z0-9_]*[^}]}}[^}]" packages/$pdone)|grep -v "cloudflare"|grep "elasticsearch/ingest_pipeline"|sort|uniq); doperl -pi -e 's/(?<!\{)(\{\{[^{][ .a-zA-Z0-9_]*[^}]}})(?!\})/{$1}/g' $fdonefor p in $(git diff --name-only HEAD~1|cut -d/ -f1,2|sort|uniq); do(cd $pelastic-package test pipeline -gelastic-package changelog add \--description "Use triple-brace Mustache templating when referencing variables in ingest pipelines." \--type bugfix \--next patch \--linkelastic#11314)>/dev/null 2>&1done
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull requestFeb 5, 2025
)This is a second pass at replacing double brace template marks with triple bracemarks. It addresses more complex uses that the sed rewrite did not find by usingPCRE via perl.[git-generate]for f in $((for p in $(yq 'select(.owner.github == "elastic/security-service-integrations")|.name' packages/**/manifest.yml \| grep -v -- '---'); dorg -l -g '*.yml' "[^{]\{\{[^{][ .a-zA-Z0-9_]*[^}]}}[^}]" packages/$pdone)|grep -v "cloudflare"|grep "elasticsearch/ingest_pipeline"|sort|uniq); doperl -pi -e 's/(?<!\{)(\{\{[^{][ .a-zA-Z0-9_]*[^}]}})(?!\})/{$1}/g' $fdonefor p in $(git diff --name-only HEAD~1|cut -d/ -f1,2|sort|uniq); do(cd $pelastic-package test pipeline -gelastic-package changelog add \--description "Use triple-brace Mustache templating when referencing variables in ingest pipelines." \--type bugfix \--next patch \--linkelastic#11314)>/dev/null 2>&1done
@efd6efd6 deleted the 7641-ssi_all_complex branchFebruary 5, 2025 22:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@andrewkrohandrewkrohandrewkroh approved these changes

Assignees

@efd6efd6

Labels

bugfixPull request that fixes a bug issueIntegration:akamaiAkamai (Community supported)Integration:atlassian_bitbucketAtlassian Bitbucket (Community supported)Integration:atlassian_jiraAtlassian Jira (Community supported)Integration:aws_bedrockAmazon BedrockIntegration:bitdefenderBitDefender (Community supported)Integration:cisa_kevsCISA Known Exploited Vulnerabilities (Community supported)Integration:cisco_duoCisco DuoIntegration:cisco_umbrellaCisco UmbrellaIntegration:crowdstrikeCrowdStrikeIntegration:falcoFalcoIntegration:forcepoint_webForcepoint Web Security (Community supported)Integration:gigamonGigamon (Partner supported)Integration:githubGitHubIntegration:keycloakKeycloak (Community supported)Integration:mimecastMimecast (Partner supported)Integration:netskopeNetskopeIntegration:oktaOktaIntegration:opencanaryOpenCanary (Community supported)Integration:qualys_vmdrQualys VMDRIntegration:slackSlack Logs (Community supported)Integration:symantec_endpointSymantec Endpoint ProtectionIntegration:sysdigSysdigIntegration:thycotic_ssThycotic Secret Server (Community supported)Integration:ti_abusechabuse.chIntegration:ti_customCustom Threat IntelligenceIntegration:ti_cybersixgillCybersixgillIntegration:ti_maltiverseMaltiverse (Partner supported)Integration:ti_mispMISPIntegration:zoomZoomTeam:Security-Service IntegrationsSecurity Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efd6@elasticmachine@andrewkroh

Comments


[8]ページ先頭

©2009-2026 Movatter.jp