Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix IPv6 cleanup#10801

Merged
marc-gr merged 7 commits intoelastic:mainfrom
marc-gr:fix/ipv6-cleanup
Sep 9, 2024
Merged

Fix IPv6 cleanup#10801
marc-gr merged 7 commits intoelastic:mainfrom
marc-gr:fix/ipv6-cleanup

Conversation

@marc-gr
Copy link
Contributor

Proposed commit message

Fix IPv6 cleanup in pipelines that replaced::ffff: directly, malforming IPV6 addresses.

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

Related issues

LaZyDK reacted with thumbs up emoji
@marc-grmarc-gr added the bugfixPull request that fixes a bug issue labelAug 16, 2024
@marc-grmarc-gr marked this pull request as ready for reviewAugust 16, 2024 09:06
@marc-grmarc-gr requested review froma team ascode ownersAugust 16, 2024 09:06
@elasticmachine
Copy link

elasticmachine commentedAug 16, 2024•
edited
Loading

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@andrewkrohandrewkroh added Integration:sentinel_one_cloud_funnelSentinelOne Cloud Funnel Integration:systemSystem Integration:sysmon_linuxSysmon for Linux Integration:windowsWindows Team:Security-Windows PlatformSecurity Windows Platform team [elastic/sec-windows-platform] Team:Security-Service IntegrationsSecurity Service Integrations team [elastic/security-service-integrations] Team:Security-Linux PlatformLinux Platform Security team [elastic/sec-linux-platform] labelsAug 16, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@pierrehilbertpierrehilbert added the Team:Elastic-Agent-Data-PlaneAgent Data Plane team [elastic/elastic-agent-data-plane] labelAug 17, 2024
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Contributor

@efd6efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Could we have test cases for these?

marc-gr reacted with thumbs up emoji
@marc-grmarc-gr requested a review fromefd6August 19, 2024 10:26
@LaZyDK
Copy link
Contributor

I'm looking forward to this one :)

Copy link
Contributor

@belimawrbelimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Approving the changes in the Windows integration.

Copy link

@Trinity2019Trinity2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good to me

Copy link
Contributor

@efd6efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit only

@andrewkrohandrewkroh added the Integration:o365Microsoft Office 365 labelAug 28, 2024
@marc-gr
Copy link
ContributorAuthor

Reverted the change in the regexp since there are samples were ips are not at the beginning, so this is more resilient as it is now.

@andrewkrohandrewkroh removed the Integration:o365Microsoft Office 365 labelSep 6, 2024
@marc-grmarc-grenabled auto-merge (squash)September 6, 2024 07:53
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube
Copy link

Quality Gate failedQuality Gate failed

Failed conditions
78.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@efd6
Copy link
Contributor

efd6 commentedSep 6, 2024

@marc-gr What are the cases that don't start with zero colons? If they exist, they should probably be included in test cases.

@marc-grmarc-grenabled auto-merge (squash)September 9, 2024 10:00
@marc-gr
Copy link
ContributorAuthor

@marc-gr What are the cases that don't start with zero colons? If they exist, they should probably be included in test cases.

They were already in the samples, tests fail if I add the change.

@marc-grmarc-gr merged commit01b8c6d intoelastic:mainSep 9, 2024
@elasticmachine
Copy link

Package sentinel_one_cloud_funnel - 1.3.1 containing this change is available athttps://epr.elastic.co/search?package=sentinel_one_cloud_funnel

@elasticmachine
Copy link

Package sysmon_linux - 1.6.3 containing this change is available athttps://epr.elastic.co/search?package=sysmon_linux

@elasticmachine
Copy link

Package system - 1.60.4 containing this change is available athttps://epr.elastic.co/search?package=system

@elasticmachine
Copy link

Package windows - 2.0.1 containing this change is available athttps://epr.elastic.co/search?package=windows

@efd6
Copy link
Contributor

^\[ is important.

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull requestFeb 4, 2025
* Fix IPv6 cleanup* Add tests examples* Improve regexp* Fix changelog quotes* Revert "Improve regexp"This reverts commit b7bfc7fb43da1661cb0a1745ec6e63de9c67cb29.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull requestFeb 5, 2025
* Fix IPv6 cleanup* Add tests examples* Improve regexp* Fix changelog quotes* Revert "Improve regexp"This reverts commit b7bfc7fb43da1661cb0a1745ec6e63de9c67cb29.
@marc-grmarc-gr deleted the fix/ipv6-cleanup branchFebruary 6, 2025 08:10
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@belimawrbelimawrbelimawr approved these changes

@bjmcnicbjmcnicbjmcnic approved these changes

@mauri870mauri870mauri870 approved these changes

@nfrittsnfrittsnfritts approved these changes

@efd6efd6efd6 approved these changes

@ishleenk17ishleenk17ishleenk17 approved these changes

+1 more reviewer

@Trinity2019Trinity2019Trinity2019 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugfixPull request that fixes a bug issueIntegration:sentinel_one_cloud_funnelSentinelOne Cloud FunnelIntegration:sysmon_linuxSysmon for LinuxIntegration:systemSystemIntegration:windowsWindowsTeam:Elastic-Agent-Data-PlaneAgent Data Plane team [elastic/elastic-agent-data-plane]Team:Security-Linux PlatformLinux Platform Security team [elastic/sec-linux-platform]Team:Security-Service IntegrationsSecurity Service Integrations team [elastic/security-service-integrations]Team:Security-Windows PlatformSecurity Windows Platform team [elastic/sec-windows-platform]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Windows system.security] IPv6 gsub causes invalid IPs

12 participants

@marc-gr@elasticmachine@LaZyDK@efd6@belimawr@bjmcnic@mauri870@Trinity2019@nfritts@ishleenk17@pierrehilbert@andrewkroh

Comments

[8]ページ先頭
©2009-2026 Movatter.jp