Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

[O11y] Migrate infraobs packages to ecs@mappings#10171

Merged
ishleenk17 merged 25 commits intoelastic:mainfrom
chavdaharnish:manual_ecs_mapping_migration
Jul 8, 2024
Merged

[O11y] Migrate infraobs packages to ecs@mappings#10171
ishleenk17 merged 25 commits intoelastic:mainfrom
chavdaharnish:manual_ecs_mapping_migration

Conversation

@harnish-crest-data
Copy link
Contributor

@harnish-crest-dataharnish-crest-data commentedJun 18, 2024•
edited
Loading

  • Enhancement

Proposed commit message

Migration performed using ecs-update. Minor manual changes are performed.

  • event.category or event.type is expecting value as an array instead of string. Hence provided the value as an array.

  • generated pipeline and system tests.

  • If the package is containing kibana version configuration as below,

    conditions:  kibana.version: "^8.10.0"

    Updated these configuration to,

    conditions:  kibana:    version: "^8.10.0"

Command

  go run github.com/andrewkroh/go-examples/ecs-update@014b35dfe4c9832b51e7c909a39a48257d6a005d \    -ecs-version=8.11.0 \    -ecs-git-ref=v8.11.0 \    -fields-yml-drop-ecs \    -kibana-version=^8.13.0 \    -drop-import-mappings \    -pr=10171 \    -owner=elastic/obs-infraobs-integrations \    packages/*

Checklist

  • I have reviewedtips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package'schangelog.yml file.
  • I have verified that Kibana version constraints are current according toguidelines.

TSDB Testing

  • Performed TSDB testing for some packages. I have put the index templates in thisdoc.
  • Performed live data collection to make sure there are no event drops.

@efd6
Copy link
Contributor

efd6 commentedJun 18, 2024•
edited
Loading

s/10135/10171/ in PR description. Also suggest using sha 014b35dfe4c9832b51e7c909a39a48257d6a005d for the tool; f7c19f8f3fa105fe1d869ed34f4d6c76c75bce2c is out of date with some fixes.

To fix up issues the best thing to do is reset --hard origin/main and re-run the command with the correct values, rather than polishing the PR.

@harnish-crest-data
Copy link
ContributorAuthor

s/10135/10171/ in PR description. Also suggest using sha 014b35dfe4c9832b51e7c909a39a48257d6a005d for the tool; f7c19f8f3fa105fe1d869ed34f4d6c76c75bce2c is out of date with some fixes.

To fix up issues the best thing to do is reset --hard origin/main and re-run the command with the correct values, rather than polishing the PR.

Cool, let me do that. Thanks!

@elasticmachine
Copy link

elasticmachine commentedJun 18, 2024•
edited
Loading

🚀 Benchmarks report

To see the full report comment with/test benchmark fullreport

@efd6
Copy link
Contributor

The issues with the sample events will need addressing. The approach that I have taken is to do manual fix-ups guided by the failures that I see after running the tool (for examplehere) and then run the tool after those fixes are merged.

harnish-crest-data reacted with thumbs up emoji

@harnish-crest-dataharnish-crest-dataforce-pushed themanual_ecs_mapping_migration branch fromc98e090 to53365dcCompareJune 18, 2024 06:54
niraj-elasticand others added2 commitsJune 24, 2024 17:01
…anual_ecs_mapping_migrationConflicts:packages/rabbitmq/changelog.yml
@harnish-crest-dataharnish-crest-data marked this pull request as ready for reviewJune 25, 2024 06:40
@harnish-crest-dataharnish-crest-data requested a review froma team as acode ownerJune 25, 2024 06:40
field: event.category
value:
- log
value: ["network"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@harnish-elastic Can you please explain this change?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The change was related to event.category will not be longer support the valuelog. So based on data stream's logs, thenetwork value suits. Hence updated the value!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you share what the exact error here and since when has this category been removed ?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

oracle_weblogic/access test-access.log:
[0] parsing field value failed: field "event.category"'s value "log" is not one of the allowed values (api, authentication, configuration, database, driver, email, file, host, iam, intrusion_detection, library, malware, network, package, process, registry, session, threat, vulnerability, web)

niraj-elastic reacted with thumbs up emoji
field: event.category
value:
- log
value: ["network"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you share what the exact error here and since when has this category been removed ?

…anual_ecs_mapping_migrationConflicts:packages/prometheus/changelog.ymlpackages/prometheus/docs/README.mdpackages/prometheus/manifest.yml
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@elastic-sonarqube
Copy link

Quality Gate failedQuality Gate failed

Failed conditions
38.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

field: event.category
value:
- log
value: ["iam"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

When i look at the attached screenshot of thisPR, i do not think that we must limit the event.category toiam only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

To unblock this PR, lets keep in "iam" for now.
If we come to a consensus that we need to add more categories, we can do that later as we are appending here.

harnish-crest-data reacted with thumbs up emoji
Copy link
Contributor

@tetianakravchenkotetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

prometheus.remote_write - LGTM!

Copy link
Member

@ishleenk17ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

Copy link
Contributor

@niraj-elasticniraj-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@ishleenk17ishleenk17 merged commitca32ce2 intoelastic:mainJul 8, 2024
@elasticmachine
Copy link

Package cassandra - 1.14.0 containing this change is available athttps://epr.elastic.co/search?package=cassandra

@elasticmachine
Copy link

Package nats - 1.7.0 containing this change is available athttps://epr.elastic.co/search?package=nats

@elasticmachine
Copy link

Package oracle_weblogic - 1.7.0 containing this change is available athttps://epr.elastic.co/search?package=oracle_weblogic

@elasticmachine
Copy link

Package prometheus - 1.18.0 containing this change is available athttps://epr.elastic.co/search?package=prometheus

@elasticmachine
Copy link

Package rabbitmq - 1.15.0 containing this change is available athttps://epr.elastic.co/search?package=rabbitmq

@elasticmachine
Copy link

Package spring_boot - 1.6.0 containing this change is available athttps://epr.elastic.co/search?package=spring_boot

@elasticmachine
Copy link

Package sql - 0.5.0 containing this change is available athttps://epr.elastic.co/search?package=sql

@elasticmachine
Copy link

Package stan - 1.7.0 containing this change is available athttps://epr.elastic.co/search?package=stan

@elasticmachine
Copy link

Package statsd_input - 0.4.0 containing this change is available athttps://epr.elastic.co/search?package=statsd_input

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@zmoogzmoogzmoog approved these changes

@tetianakravchenkotetianakravchenkotetianakravchenko approved these changes

@ishleenk17ishleenk17ishleenk17 approved these changes

@MichaelKatsoulisMichaelKatsoulisAwaiting requested review from MichaelKatsoulisMichaelKatsoulis was automatically assigned from elastic/obs-cloudnative-monitoring

@constanca-mconstanca-mAwaiting requested review from constanca-mconstanca-m was automatically assigned from elastic/obs-cloudnative-monitoring

@agithomasagithomasAwaiting requested review from agithomas

+2 more reviewers

@milan-elasticmilan-elasticmilan-elastic approved these changes

@niraj-elasticniraj-elasticniraj-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@harnish-crest-data@efd6@elasticmachine@milan-elastic@zmoog@tetianakravchenko@agithomas@ishleenk17@niraj-elastic@andrewkroh
[8]ページ先頭
©2009-2026 Movatter.jp