- Notifications
You must be signed in to change notification settings - Fork1.2k
Add Windows test workflow and net462 test target#7769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4e34f9e toc3eda1dCompare| <CheckEolTargetFramework>false</CheckEolTargetFramework> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Workaround for:
rror NU1004: The project's runtime identifiers have changed from. Project's runtime identifiers: , lock file's runtime identifiers win7-x86.The packages lock file is inconsistent with the project dependencies so restore can't be run in locked mode. Disable the RestoreLockedMode MSBuild property or pass an explicit --force-evaluate option to run restore to update the lock file.This is a known long standing issue (see comments).
Another workaround that does not involve disabling lock files, would be this one:
NuGet/Home#9195 (comment)
| public override void OnBeforeTestsRun() => TestConfiguration.Instance.DumpConfiguration(); | ||
| public override void OnBeforeTestsRun() | ||
| { | ||
| VerifierSettings.DerivePathInfo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[ModuleInitializer] is not available prior to NET5.
This snippet is moved from there.
| @@ -11,7 +11,7 @@ | |||
| <ItemGroup> | |||
| <PackageReference Include="Bogus" Version="22.1.2" /> | |||
| <PackageReference Include="Elastic.Elasticsearch.Managed" Version="0.3.5" /> | |||
| <PackageReference Include="Elastic.Elasticsearch.Managed" Version="0.4.1" /> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seeelastic/elasticsearch-net-abstractions#58 for details.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| query: { | |||
| function_score: { | |||
| boost: 1.1, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
NETFX is not fully IEEE compliant which messes with our roundtrip serialization tests. Particularilyfloat values seem to cause problems. As a workaround I changed these tests to use values that can be represented as integers.
More details:dotnet/runtime#435 (comment)
No description provided.