- Notifications
You must be signed in to change notification settings - Fork25.6k
available_processors field in CAT Nodes#135936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
available_processors field in CAT Nodes#135936
Uh oh!
There was an error while loading.Please reload this page.
Conversation
update to client docs will follow soon (I'll link it here before merging) |
Pinging @elastic/es-data-management (Team:Data Management) |
Hi@piotrsulkowski-elastic, I've created a changelog YAML for you. |
31c85f0 to76b9bf8Compare9aa7eb2 tod7b8f64Compare41aa94d toa162172Compare5820018 to7d847d5CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
One small change to theTransportVersion declaration but otherwise looks like a good change 👍🏻
| }else { | ||
| this.loadAverage =null; | ||
| } | ||
| this.availableProcessors =in.getTransportVersion().supports(TransportVersion.fromName(AVAILABLE_PROCESSORS_TRANSPORT_VERSION)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ThisTransportVersion should be a static field so it's only called once and can be used in other places if required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks, fixed
7d847d5 to8b20f88CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Changes LGTM 👍🏻
d228a30 to9c82443CompareCat nodes REST action will return an extra field:available_processors. It is now also part of all responseswhich contain Os Stats.Closeselastic#134692
9c82443 to0c6e765Compare33743c1 intoelastic:mainUh oh!
There was an error while loading.Please reload this page.
Cat nodes REST action will return an extra field:available_processors. It is now also part of all responseswhich contain Os Stats.Closeselastic#134692
Cat nodes REST action will return an extra field:
available_processors. It is now also part of all responses which contain Os Stats.
Closes#134692