Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork428
Deps: minimize Tokio features#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for limiting the features. It doesn't seem like there were many packages that were pruned as a result, but it's always good to have.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Clap does special things behind the scenes before it exits.
Looks great, thank you! |
Thank you so much for the feedback. I definitely learned something new today about the |
Hello there! I noticed that the dependency on Tokio uses the
fullfeature. This PR aims to resolve this by minimizing the enabled features.While I was in
main.rs, I also removed the use of thetokio::mainmacro. Now, CLI parsing occurs earlier than starting up the Tokio runtime. If parsing fails, then the program terminates early (i.e. no runtime initialization required). The observable behavior should still be the same.If there are any issues, feel free to point them out. I'd gladly resolve them. Thanks! 🎉