- Notifications
You must be signed in to change notification settings - Fork403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Deps: minimize Tokio features#25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for limiting the features. It doesn't seem like there were many packages that were pruned as a result, but it's always good to have.
Clap does special things behind the scenes before it exits.
Looks great, thank you! |
Thank you so much for the feedback. I definitely learned something new today about the |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there! I noticed that the dependency on Tokio uses the
fullfeature. This PR aims to resolve this by minimizing the enabled features.While I was in
main.rs, I also removed the use of thetokio::mainmacro. Now, CLI parsing occurs earlier than starting up the Tokio runtime. If parsing fails, then the program terminates early (i.e. no runtime initialization required). The observable behavior should still be the same.If there are any issues, feel free to point them out. I'd gladly resolve them. Thanks! 🎉