- Notifications
You must be signed in to change notification settings - Fork403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Support reading client/server secret from an environment variable#18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you for doing this! Is there a reason why the environment variable names are different between client and server though, rather than justBORE_SECRET? I can't think of any case where a user would set these two environment variables to different values, since the secret is intended to be the same on both ends.
Good point, I guess I haven't thought of that 🐻 Updated the PR. |
Could someone maybe use bore to hope traffic between a few servers? That's the only reason I could see both bore client and server being used on the same machine. |
gngeorgiev commentedApr 13, 2022
@praveenperera You can just reassign the env variable per each instance: BORE_SECRET=$BORE_CLIENT_SECRET ./clientBORE_SECRET=$BORE_SERVER_SECRET ./server |
Thank you! |
This PR adds
envfeature toclapfor defining custom variables to read the values of--secretarguments from the environment.BORE_SECRET: sets the client/server secretcloses#17