Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

CRAN RC: 0.8.3#332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
IndrajeetPatil merged 17 commits intomainfromrc-cran-083
Mar 24, 2024
Merged

CRAN RC: 0.8.3#332

IndrajeetPatil merged 17 commits intomainfromrc-cran-083
Mar 24, 2024

Conversation

IndrajeetPatil
Copy link
Member

@IndrajeetPatilIndrajeetPatil commentedMar 23, 2024
edited
Loading

Closes#330

@IndrajeetPatil
Copy link
MemberAuthor

@strengejacke Can you go through thechanges in snapshots and confirm that this is expected?

I am surprised how much we have reduced the size of points; they are barely visible.

@codecovCodecov
Copy link

codecovbot commentedMar 23, 2024
edited
Loading

Codecov Report

Attention: Patch coverage is66.66667% with5 lines in your changes are missing coverage. Please review.

Project coverage is 43.57%. Comparing base(bd5b6e1) to head(83e62c4).
Report is 2 commits behind head on main.

FilesPatch %Lines
R/scale_color_social.R0.00%2 Missing⚠️
R/scale_color_bluebrown.R50.00%1 Missing⚠️
R/scale_color_metro.R50.00%1 Missing⚠️
R/scale_color_pizza.R50.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main     #332      +/-   ##==========================================- Coverage   43.89%   43.57%   -0.33%==========================================  Files          67       67                Lines        4882     4909      +27     ==========================================- Hits         2143     2139       -4- Misses       2739     2770      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@strengejacke
Copy link
Member

@strengejacke Can you go through thechanges in snapshots and confirm that this is expected?

I am surprised how much we have reduced the size of points; they are barely visible.

Maybe we can revert that? Points looked too big in check_model(), but rather small in single plots.

@strengejacke
Copy link
Member

Would you say it's ok now, or increase dot size even more?

@IndrajeetPatil
Copy link
MemberAuthor

Would you say it's ok now, or increase dot size even more?

Yes, looks much better now!

@IndrajeetPatilIndrajeetPatil merged commit1f50306 intomainMar 24, 2024
@IndrajeetPatilIndrajeetPatil deleted the rc-cran-083 branchMarch 24, 2024 18:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@strengejackestrengejackestrengejacke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRAN release?
2 participants
@IndrajeetPatil@strengejacke

[8]ページ先頭

©2009-2025 Movatter.jp