Commit8049d61

committed

add checkstyle rules, fix ArrayTypeStyle

1 parentc1fda98 commit8049d61Copy full SHA for 8049d61

File tree

+10

-3

lines changed

checkstyle.xml
scribejava-core/src
- main/java/com/github/scribejava/core/model
  - ParameterList.java
- test/java/com/github/scribejava/core/utils
  - OAuthEncoderTest.java

+10

-3

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -54,5 +54,12 @@`
`54`	`54`	`<modulename="SimplifyBooleanReturn"/>`
`55`	`55`	`<modulename="StringLiteralEquality"/>`
`56`	`56`	`<modulename="UnnecessaryParentheses"/>`
	`57`	`+ <modulename="AvoidStarImport"/>`
	`58`	`+ <modulename="IllegalImport">`
	`59`	`+ <propertyname="illegalPkgs"value="sun, junit.framework"/>`
	`60`	`+ </module>`
	`61`	`+ <modulename="RedundantImport"/>`
	`62`	`+ <modulename="UnusedImports"/>`
	`63`	`+ <modulename="ArrayTypeStyle"/>`
`57`	`64`	`</module>`
`58`	`65`	`</module>`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public void addAll(ParameterList other) {`
`73`	`73`	`publicvoidaddQuerystring(StringqueryString) {`
`74`	`74`	`if (queryString !=null &&queryString.length() >0) {`
`75`	`75`	`for (Stringparam :queryString.split(PARAM_SEPARATOR)) {`
`76`		`-finalStringpair[] =param.split(PAIR_SEPARATOR);`
	`76`	`+finalString[]pair =param.split(PAIR_SEPARATOR);`
`77`	`77`	`finalStringkey =OAuthEncoder.decode(pair[0]);`
`78`	`78`	`finalStringvalue =pair.length >1 ?OAuthEncoder.decode(pair[1]) :EMPTY_STRING;`
`79`	`79`	`params.add(newParameter(key,value));`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ public void shouldThrowExceptionIfStringToDecodeIsNull() {`
`53`	`53`	`@Test`
`54`	`54`	`publicvoidshouldPercentEncodeCorrectlyTwitterCodingExamples() {`
`55`	`55`	`// These tests are part of the Twitter dev examples here -> https://dev.twitter.com/docs/auth/percent-encoding-parameters`
`56`		`-finalStringsources[] = {"Ladies + Gentlemen","An encoded string!","Dogs, Cats & Mice"};`
`57`		`-finalStringencoded[] = {"Ladies%20%2B%20Gentlemen","An%20encoded%20string%21","Dogs%2C%20Cats%20%26%20Mice"};`
	`56`	`+finalString[]sources = {"Ladies + Gentlemen","An encoded string!","Dogs, Cats & Mice"};`
	`57`	`+finalString[]encoded = {"Ladies%20%2B%20Gentlemen","An%20encoded%20string%21","Dogs%2C%20Cats%20%26%20Mice"};`
`58`	`58`
`59`	`59`	`for (inti =0;i <sources.length;i++) {`
`60`	`60`	`Assert.assertEquals(encoded[i],OAuthEncoder.encode(sources[i]));`

Comments

(0)