- Notifications
You must be signed in to change notification settings - Fork47
Add ALTREP guard to prevent unsafe R calls from ALTREP methods#1797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge3 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+59 −26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
Co-authored-by: krlmlr <1741643+krlmlr@users.noreply.github.com>
CopilotAI changed the title[WIP] Fix safety issue when calling rapi_error_with_context in ALTREP methodsAdd ALTREP guard to prevent unsafe R calls from ALTREP methodsDec 1, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
rapi_error_with_context()jumps into R, which is unsafe from ALTREP method callbacks and can cause stack overflows.Changes
AltrepGuardclass (src/include/rapi.hpp): Thread-local RAII guard with depth counter to track ALTREP method execution contextrapi_error_with_context()modification (src/utils.cpp): When guard is active, throwsstd::runtime_errorinstead of calling into R. TheBEGIN_CPP11/END_CPP11macros catch this and convert to R error safely.src/reltoaltrep.cpp): AddedAltrepGuard guard;to all 11 ALTREP method callbacksExample
Error messages change from multi-line format to
Context: Messagebut retain same information.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
cloud.r-project.org/opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -q -e options(repos~+~=~+~c(CRAN~+~=~+~'REDACTED'));~+~install.packages(c('DBI',~+~'testthat',~+~'cpp11',~+~'rlang'),~+~type='source')(dns block)cran.r-project.org/opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -q -e install.packages(c('DBI',~+~'testthat',~+~'cpp11',~+~'rlang'),~+~repos='REDACTED')(dns block)/usr/bin/curl curl -sI REDACTED(dns block)p3m.dev/opt/R/4.5.2/lib/R/bin/exec/R /opt/R/4.5.2/lib/R/bin/exec/R -q -e options(repos~+~=~+~c(CRAN~+~=~+~'REDACTED'));~+~install.packages(c('DBI',~+~'testthat',~+~'cpp11',~+~'rlang'))(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
rapi_error_with_context()is unsafe from ALTREP methods #1796💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.