- Notifications
You must be signed in to change notification settings - Fork47
feat: Safeguard against deadlocks when accidentally issuing queries from the progress bar handler or other callbacks#1475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
15 commits Select commitHold shift + click to select a range
5470e66 Initial plan
Copilot0ebb29e Add ScopedInterruptHandler to rapi_prepare to prevent deadlock
Copilotc9d0a0c Add documentation comment explaining the deadlock fix
Copilot5d51312 Fix HandleInterrupt() usage pattern and add ScopedInterruptHandler pr…
Copilot034ed60 Adapt HandleInterrupt() to call cpp11::stop() instead of returning TR…
Copilotd35bdab Merge branch 'main' into copilot/fix-1397
krlmlr54edad2 Add rapi_connection_valid C++ entry point to avoid deadlock in dbIsVa…
Copilot9624b5e Merge branch 'main' into copilot/fix-1397
krlmlrb0e380c Merge branch 'main' into copilot/fix-1397
krlmlr0c598c6 Merge branch 'main' into copilot/fix-1397
krlmlrd546bc1 Deps
krlmlr79c3a3a Register
krlmlr58f3a15 ref
krlmlr205920f Message
krlmlr2b68b14 Format
krlmlrFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Deps
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitd546bc1fef8ec3dfff74b64640fb503d7af7e199
There are no files selected for viewing
1 change: 1 addition & 0 deletionssrc/register.dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| register.o: \ | ||
| include/convert.hpp \ | ||
| include/rapi.hpp \ | ||
| include/signal.hpp \ | ||
| include/typesr.hpp \ | ||
| register.cpp \ |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.