Add df data and tz type columns back into the same loc after type con…#150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

evertlammerts merged 1 commit intoduckdb:v1.4-andiumfromevertlammerts:arrow_col_fix

Oct 31, 2025

Merged

Add df data and tz type columns back into the same loc after type con…#150

evertlammerts merged 1 commit intoduckdb:v1.4-andiumfromevertlammerts:arrow_col_fix

Oct 31, 2025

Conversation

Copy link

Collaborator

evertlammerts commentedOct 31, 2025

…version

fixes#120

Tishj approved these changes

Oct 31, 2025

View reviewed changes

Copy link

Collaborator

Tishj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks LGTM

evertlammertsenabled auto-merge

October 31, 2025 12:58

evertlammerts mentioned this pull request

Oct 31, 2025

Fix pandas column ordering issue with TIMESTAMPTZ types#149

Closed

Copy link

Contributor

paultiq commentedOct 31, 2025

Why not just

staticvoidReplaceDFColumn(PandasDataFrame&df,constchar*col_name,idx_tidx,constpy::handle&new_value) {df.attr("__setitem__")(col_name,new_value);}

* This is same as used in FrameFromNumpy.

In Python, we wouldn't perform two operations to replace a column (drop then insert in position). We'd just set it:df["mycol"] = ...., which preserves position.

... As a general rule, explicit "inplace" params in Pandas is something to avoid. Seehttps://pandas.pydata.org/pdeps/0008-inplace-methods-in-pandas.html for a longer discussion of if.