- Notifications
You must be signed in to change notification settings - Fork2.7k
Add comments to cardinality estimator code#19973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Tmonster wants to merge1 commit intoduckdb:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+94 −70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With@hawkfish working on IEJoin improvements and all of the previous work on ASOF joins, it may be a good idea to update our cardinality estimation logic given these new join types/algorithms.
With that in mind, I thought I would spend a bit of time cleaning up code & renaming structures/classes so that it becomes easier for future engineers to modify the logic to account for different join types.
This PR is strictly adding comments and changing variable names. There should be no actual logic changes (if there are please point them out).
Most of changing of struct names/class names is to move away from the one statistic during CE of
tdomto many possible statistics.tdomhas also been renamed todistinct_countas I believe that better describes what HLL measures. If we add extra statistics duringExtract<LogicalOperatorType>Statisticswe can better estimate cardinalities of ASOF and IE joins.