NotificationsYou must be signed in to change notification settings
Fork2.7k
Star34.5k

[Profiling] Check that file type set by`profiling_output` matches output type#19946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

maiadegraaf wants to merge4 commits intoduckdb:main

base:main

Choose a base branch

frommaiadegraaf:profiling-file-override-bug

Draft

[Profiling] Check that file type set by`profiling_output` matches output type#19946

maiadegraaf wants to merge4 commits intoduckdb:mainfrommaiadegraaf:profiling-file-override-bug

Conversation

Copy link

Contributor

maiadegraaf commentedNov 26, 2025•
edited
Loading

Add a check that makes sure that the file set byprofiling_output matches the output type set byenable_profiling.

# Both the file types and the outputs match!PRAGMA enable_profiling='json';PRAGMA profiling_output='/profiler.json';# Now the output doesn't match the file type anymore :(PRAGMA enable_profiling='html';-- Parser Error: Profiler file type (/profiler.json) must either have the same file extension as the profiling output type (html), or be a '.txt' file. Set 'profiling_output' to a 'html' file or run "RESET profiling_output" first.

This prevents unintended file overwrites, for example:

PRAGMA profiling_output='my_important_database.db';-- Parser Error: Invalid output file type: db

Pottential breaking change:

Since the default profiling output isquery_tree, if you set theprofiling_output to a different file type without first changing the profiling output type it will throw an error.

Closes:https://github.com/duckdblabs/duckdb-internal/issues/6469