- Notifications
You must be signed in to change notification settings - Fork2.7k
Sanitize JoinPath handling#19923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Mytherin commentedNov 25, 2025
Thanks for the PR! Is there a particular issue that this is solving - or is this just picking up a random FIXME in the code? I'm not opposed to the changes but if there is an underlying bug this is addressing adding tests for those would be good. We might also want to expose this method in the SQL layer in |
feichai0017 commentedNov 26, 2025
This isn’t random cleanup. JoinPath is used for temp files, logs, and test paths. Today it just glues strings, so an absolute RHS gives |
Mytherin commentedNov 27, 2025
Thanks for the clarification - adding the SQL function in a follow-up makes sense to me.
Maybe we could also add some special tests for Windows specifically, i.e. when the separator is |
feichai0017 commentedNov 27, 2025
Sure! I will add more edge test cases |
feichai0017 commentedNov 29, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
|
Improve
FileSystem::JoinPathto normalize separators and dot segments, respect absolute RHS, preserve URI schemes, and handle drive prefixes.Added file system tests covering separator normalization, .. folding, absolute override, and repeated separator cleanup.