Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge v1.2.2 into main#17037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Mytherin merged 65 commits intoduckdb:mainfromcarlopi:merge_v122_in_main
Apr 9, 2025
Merged

Conversation

@carlopi
Copy link
Contributor

@carlopicarlopi commentedApr 8, 2025
edited
Loading

This brings in the latest changes inv1.2-histrionicus intomain.

The more complex bit was merging.github/config/out_of_tree.cmake, that is still likely will not really compile due to patches being applied to different commits.

Four regressions:

  • httpfs had sha c22532453e9fab8404f91729708d9f35e23d323d inv1.2.2, rolling back a few commits to85ac4667bcb0d868199e156f8dd918b0278db7b9 due to changes in Secret interface
  • avro is currently disabled, needs a patch and re-enabling
  • delta is currently disabled, needs a different set of patches and re-enabling
  • aws tests are currently skipped

And an unrelated change, that was needed due to incompatibility:

  • bump spatial and remove the patch

There are relevant issues to solve them and can be handled piece by piece.

Mytherinand others added30 commitsMarch 14, 2025 16:10
* Only Finalize when all threads have been merged.fixes:duckdb#16617fixes: dudblabs/duckdb-internal#4425
I picked up the previous work onduckdb#16331 by@Tishj and added atest.As far as I can tell, setting the `gstate` to uninitialised is fine,here, and flushing before deleting fixes the issue.
This PRfixesduckdb#16942 As mentioned[here](https://duckdb.org/docs/stable/sql/dialect/sql_quirks#nan-values)DuckDB does not follow the IEEE-754 behavior for nan comparisons,instead it makes NaN the biggest value in the floating point ordering.This PR adjusts the pyarrow dataset filters we create when pushingDuckDB table filters in to pyarrow.
When embedding DuckDB, it is some times important to make sure alloutput follows a certain structure (example JSON) and/or goes tospecific stream.This PR allows overriding the Printer's default behavior.
Co-authored-by: Carlo Piovesan <piovesan.carlo@gmail.com>
bump duckdb-httpfs, and duckdb-aws to latest version ofv1.2-histrionicusAlso removing `DONT_LINK` from avro since duckdb-iceberg tries toautomatically load it, and if it is not available duckdb-iceberg willthrough an error. This means any time iceberg is autoloaded and avro isnot available/linked, then statements/tests will fail.EDIT: not bumping iceberg in this PR. Want to try and isolate errors.EDIT2: Not bumping aws, there seems to be an issue with windows andprovider `credential_chain`. Want to try and debug it on the windowslaptop first
@carlopicarlopi marked this pull request as draftApril 8, 2025 18:16
@carlopicarlopi marked this pull request as ready for reviewApril 8, 2025 20:57
@duckdb-draftbotduckdb-draftbot marked this pull request as draftApril 8, 2025 22:45
@carlopicarlopi marked this pull request as ready for reviewApril 9, 2025 07:27
@carlopi
Copy link
ContributorAuthor

carlopi commentedApr 9, 2025
edited
Loading

@Mytherin: I think some changes were still tied to extensions in v1.2-histrionicus, and this looks to me a reasonable compromise: bumping what can be bumping, and skipping in some places.

Note thatmain was skipping iceberg that is now re-introduced.

If Windows Extensions job passes this is good to go for me.

@carlopi
Copy link
ContributorAuthor

Windows Extensions fails on what looks to me an irrelevant spatial test, unsure if path is skipping also spatial tests.

@Maxxen
Copy link
Member

Spatial test is fixed on spatial main branch - solution is just bumping to use that commit

@Maxxen
Copy link
Member

4be6065edc313a53ff2196ff79c11a0d5e249720

carlopi reacted with thumbs up emoji

@duckdb-draftbotduckdb-draftbot marked this pull request as draftApril 9, 2025 10:36
@carlopicarlopi marked this pull request as ready for reviewApril 9, 2025 10:36
@duckdb-draftbotduckdb-draftbot marked this pull request as draftApril 9, 2025 10:44
@carlopicarlopi marked this pull request as ready for reviewApril 9, 2025 10:47
@carlopi
Copy link
ContributorAuthor

Thanks@Maxxen, moving to4be6065edc313a53ff2196ff79c11a0d5e249720 and removing patch +APPLY_PATCHES works

@MytherinMytherin merged commitbbdc794 intoduckdb:mainApr 9, 2025
54 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull requestMay 15, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull requestMay 15, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull requestMay 16, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull requestMay 16, 2025
krlmlr added a commit to duckdb/duckdb-r that referenced this pull requestMay 17, 2025
@carlopicarlopi deleted the merge_v122_in_main branchAugust 17, 2025 20:36
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@carlopi@Mytherin@Maxxen@NiclasHaderer@bleskes@Tmonster@taniabogatsch@Tishj

[8]ページ先頭

©2009-2025 Movatter.jp