- Notifications
You must be signed in to change notification settings - Fork9
added 'text-shadow'-property and improved 'text-box'#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
“//“ comments broke my (S)CSS Rendering. “/* */“-comments are safer
added text-shadow attribute with properties in the CSS-Comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the PR
| @@ -102,7 +102,7 @@ | |||
| 'box-shadow': | |||
| 'prefix': 'bs' | |||
| 'body': """ | |||
| // h-length, v-length, blur, spread, colour | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Don't change the sass comment. I and scss-lint prefer// comments.
| @@ -543,7 +549,7 @@ | |||
| 'box-shadow': | |||
| 'prefix': 'bs' | |||
| 'body': """ | |||
| // h-length, v-length, blur, spread, colour | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Use// for scss, sass, and less. For css, use/* */. This will mean we will have to break out the shadow snippets to a third section.
| 'text-shadow': | ||
| 'prefix': 'ts' | ||
| 'body': """ | ||
| /* h-shadow, v-shadow, blur, colour */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The comment is not necessary. Feel free to leave out if desired.
| 'text-shadow': | ||
| 'prefix': 'ts' | ||
| 'body': """ | ||
| /* h-shadow, v-shadow, blur, colour */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Likewise, use// for scss,/* */ for css.
I added the 'text-shadow'-property because i think it's an important one and used a lot. Also i changed the comment that was included with the completion of the 'text-box'-property to another comment Form because sometimes CSS breaks with "//"-Commets.