dropbox/dropbox-sdk-pythonPublic

NotificationsYou must be signed in to change notification settings
Fork329
Star957

PEP8 Standards Fixes#97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

Dmchale92 wants to merge4 commits intodropbox:master

base:master

Choose a base branch

fromDmchale92:master

Open

PEP8 Standards Fixes#97

Dmchale92 wants to merge4 commits intodropbox:masterfromDmchale92:master

Conversation

Copy link

Dmchale92 commentedMar 15, 2017

--------- BEGIN META VARIABLES --------
Project : dropbox-sdk-python
Task : PEP8 Standards Fixes
Done : 3-16-17
--------- END META VARIABLES --------

PEP8 Standards Fixes

b3d4ba1

--------- BEGIN META VARIABLES --------Project : dropbox-sdk-pythonTask : PEP8 Standards FixesDone : 3-16-17--------- END META VARIABLES --------

posita suggested changes

Mar 15, 2017

View reviewed changes

Copy link

Contributor

posita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the contribution!

Please consider updating theflake8 section oftox.ini and theMESSAGES CONTROL section of.pylintrc to reflect the changes. This will likely mean turning back on certain linter options, but some experimentation may be necessary.

example/back-up-and-restore/backup-and-restore-example.py Outdated

		print("Finding available revisions on Dropbox...")
		entries = dbx.files_list_revisions(BACKUPPATH, limit=30).entries # pylint: disable=no-member
		entries = dbx.files_list_revisions(
		BACKUPPATH, limit=30).entries # pylint: disable=no-member

Copy link

Contributor

positaMar 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Breaking up this line confuses the linter. Consider instead:

revisions=dbx.files_list_revisions(BACKUPPATH,limit=30)entries=revisions.entries# pylint: disable=no-member

Dmchale92 added3 commits

March 16, 2017 11:54

Breaking up entry revision retrieval to address linter confusion

514142e

--------- BEGIN META VARIABLES --------Project : dropbox-sdk-pythonTask : Cleaning up backup-and-restore-example.pyDone : 3-16-17--------- END META VARIABLES --------

Fixing E261 - at least two spaces before inline comment

1d52760

--------- BEGIN META VARIABLES --------Project : dropbox-sdk-pythonTask : Addressing linter error on travis CI build for prior commit tobackup-and-restore-example.pyDone : 3-16-17--------- END META VARIABLES --------

--------- BEGIN META VARIABLES --------

b046c73

Project : dropbox-sdk-pythonTask : Updating tox.ini to ignore E1101 (no-member)Done : 3-16-17--------- END META VARIABLES --------

Copy link

Author

Dmchale92 commentedMar 16, 2017•
edited
Loading

Hey Matt, my pleasure. Broke up the revision retrieval code, and fixed a subsequent E261 error. Also added E1101 to tox.ini, it looks like MESSAGES CONTROL for .pylintrc already has locally-disabled disabled.

posita approved these changes

Mar 17, 2017

View reviewed changes

posita suggested changes

Mar 22, 2017

View reviewed changes

Copy link

Contributor

posita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@Dmchale92, it looks good. If you can squash commits, I'll merge. Thanks!

Copy link

Contributor

posita commentedMar 22, 2017

As an aside,ez_setup.py comes from elsewhere (formerly fromPEAK, now fromPyPA). We might consider removing it altogether in the future and leave bootstrappingsetuptools up to the installer. I think most modern versions of Python already include it anyway.

posita force-pushed themaster branch 2 times, most recently fromf2cf463 toafadb2dCompare

May 11, 2017 18:21

Copy link

Contributor

rogebrd commentedMar 30, 2020

Hello, If you are still interested in updating this piece of code, please acknowledge this message and make the necessary updates.

Copy link

CLAassistant commentedApr 16, 2022

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}

Labels

None yet

4 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PEP8 Standards Fixes#97

Are you sure you want to change the base?

PEP8 Standards Fixes#97

Uh oh!

Conversation

Dmchale92 commentedMar 15, 2017

Uh oh!

posita left a comment

Choose a reason for hiding this comment

Uh oh!

positaMar 15, 2017

Choose a reason for hiding this comment

Uh oh!

Dmchale92 commentedMar 16, 2017•
edited
Loading

Uh oh!

Uh oh!

posita left a comment

Choose a reason for hiding this comment

Uh oh!

posita commentedMar 22, 2017

Uh oh!

rogebrd commentedMar 30, 2020

Uh oh!

CLAassistant commentedApr 16, 2022

Uh oh!

Uh oh!

Movatterモバイル変換

PEP8 Standards Fixes#97

Are you sure you want to change the base?

PEP8 Standards Fixes#97

Uh oh!

Conversation

Dmchale92 commentedMar 15, 2017

Uh oh!

posita left a comment

Choose a reason for hiding this comment

Uh oh!

positaMar 15, 2017

Choose a reason for hiding this comment

Uh oh!

Dmchale92 commentedMar 16, 2017• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

posita left a comment

Choose a reason for hiding this comment

Uh oh!

posita commentedMar 22, 2017

Uh oh!

rogebrd commentedMar 30, 2020

Uh oh!

CLAassistant commentedApr 16, 2022

Uh oh!

Uh oh!

Dmchale92 commentedMar 16, 2017•
edited
Loading