Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Refresh support matrix for Python 3.12#490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
maxbelanger wants to merge9 commits intomain
base:main
Choose a base branch
Loading
fromrefresh
Draft

Conversation

maxbelanger
Copy link
Contributor

@maxbelangermaxbelanger commentedMay 6, 2024
edited
Loading

  • CI now tests Python 3.9, 3.10, 3.11, 3.12, we no longer test 3.5, 3.6, 3.7.
  • We no longer advertise support for Python 2.7. This is inevitable as GitHub action runners no longer support Python 2.7, so we can no longer run CI for this version.
  • We refer to runners with an explicit version (e.g.macos-13 , no more*-latest). This previously broke most test configurations when macOS defaulted to 14, which is Apple Silicon.
  • Addsetuptools toinstall_requires, since on Python 3.12+ this is no longer built-in. The library depends on this at runtime (pkg_resources).

Supersedes#481 and#484. These changes will require a major version bump.

@codecovCodecov
Copy link

codecovbot commentedMay 6, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.56%. Comparing base(487793d) to head(711cacc).

❗ Current head711cacc differs from pull request most recent heada5912f6. Consider uploading reports for the commita5912f6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main     #490      +/-   ##==========================================+ Coverage   63.69%   64.56%   +0.86%==========================================  Files          31       31                Lines       52609    53896    +1287       Branches     3841     3841              ==========================================+ Hits        33510    34798    +1288+ Misses      19064    19063       -1  Partials       35       35
FlagCoverage Δ
unit64.56% <ø> (+0.86%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@maxbelanger
Copy link
ContributorAuthor

Note that integration tests are green save for one (malformed token handling). That seems to be a backend change that should be investigated separately.

@maxbelangermaxbelanger marked this pull request as ready for reviewMay 6, 2024 23:55
@maxbelangermaxbelanger mentioned this pull requestMay 7, 2024
5 tasks
@maxbelangermaxbelanger marked this pull request as draftMay 8, 2024 18:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sdericksonsdericksonAwaiting requested review from sderickson

@greg-dbgreg-dbAwaiting requested review from greg-db

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@maxbelanger

[8]ページ先頭

©2009-2025 Movatter.jp