Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Extend test matrix up to 3.12#484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
foarsitter wants to merge2 commits intodropbox:main
base:main
Choose a base branch
Loading
fromfoarsitter:py312

Conversation

foarsitter
Copy link

@foarsitterfoarsitter commentedOct 31, 2023•
edited
Loading

In the same vein as#481, this PR updates the test matrix & classifiers up to the most recent 3.12.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed theCLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Doestox pass?
  • Do the tests pass?

hugovk, velaia, and ZbigniewRA reacted with rocket emoji
@CLAassistant
Copy link

CLAassistant commentedOct 31, 2023•
edited
Loading

CLA assistant check
All committers have signed the CLA.

@greg-db
Copy link
Contributor

Thanks for putting this together! I'll ask the team to review this.

foarsitter reacted with rocket emoji

@hugovk
Copy link

Does this fail on 3.12 with#483?

@@ -77,6 +77,10 @@
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
Copy link

@sarahboycesarahboyceNov 18, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

'pytest-runner == 5.2.0',

I think something like'setuptools; python_version>="3.12"' should be added to thesetup_requires list.
Without this I can't create a virtual env for this library on Python 3.12

See:https://docs.python.org/3/whatsnew/3.12.html

  • gh-95299: Do not pre-install setuptools in virtual environments created withvenv. This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in theactivated virtual environment.

@foarsitter
Copy link
Author

@sarahboyce
Copy link

sarahboyce commentedNov 18, 2023•
edited
Loading

@hugovk It did not fail on 3.12 for the CI:https://github.com/foarsitter/dropbox-sdk-python/actions/runs/6707504248

@foarsitter this is becauserequirements.txt also includes some requirements for development includingsphinx which installssetuptools. Ref raw logs of the action:

2023-10-31T13:53:47.3735410Z Collecting setuptools (from babel>=2.9->sphinx->-r requirements.txt (line 9))

I think the packages in therequirements.txt under# Other dependencies for development should be in their own requirements file and not installed in the CI (sphinx for example is explicitly installed in the docs ci step anyway).

If you removesphinx fromrequirements.txt, I think that the Python 3.12 ci will fail.
I believe#484 (comment) is needed. I can't activate a virtual environment here on Python 3.12 without this change.

@foarsitter
Copy link
Author

@sarahboyce do you think it is sufficient to not pin setuptools and let pip decide? Thanks for pointing out that sphinx was installing setuptools in this case.

I added an issue to move to pyproject.toml:#487

Copy link

@sarahboycesarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@foarsitter this is great! 🌟
Good idea to raise a separate issue around the setup, this PR achieves what we need 👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@sarahboycesarahboycesarahboyce approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@foarsitter@CLAassistant@greg-db@hugovk@sarahboyce
[8]ページ先頭
©2009-2025 Movatter.jp