Thanks!

@starforever might I also suggest changingweb_app_session torequest, as they are basically the same thing and the namerequest is more intuitive.

Ok, I think I understand.

DropboxOAuth2Flow class needs to take in web_app_session. However, the documentation would be wrong for Django's implementation because the URL handlers for/dropbox-auth-start and/dropbox-auth-finish (that is, the functionsdropbox_auth_start anddropbox_auth_finish) take inrequest as the first (and in function-based views, the only) argument.

It is that request's session (request.session) that needs to be passed to DropboxOAuth2Flow __init__ method.

My point is,web_app_session needs to be passed to DropboxOAuthFlow class, but in Django, thatweb_app_session is found in therequest object asrequest.session. Also,request is the first parameter the URL handler takes in;

Therefore for Django:

defget_dropbox_auth_flow(web_app_session):redirect_uri="https://my-web-server.org/dropbox-auth-finish"returnDropboxOAuth2Flow(APP_KEY,APP_SECRET,redirect_uri,web_app_session,"dropbox-auth-csrf-token")# URL handler for /dropbox-auth-startdefdropbox_auth_start(request):authorize_url=get_dropbox_auth_flow(request.session).start()redirect_to(authorize_url)# URL handler for /dropbox-auth-finishdefdropbox_auth_finish(request):try:oauth_result= \get_dropbox_auth_flow(request.session).finish(request.query_params)exceptBadRequestException,e:http_status(400)    ...

For Flask, session is global. We would just need to access it directly:

fromflaskimportsession,requestdefget_dropbox_auth_flow(web_app_session):redirect_uri="https://my-web-server.org/dropbox-auth-finish"returnDropboxOAuth2Flow(APP_KEY,APP_SECRET,redirect_uri,web_app_session,"dropbox-auth-csrf-token")# URL handler for /dropbox-auth-start@app.route('/dropbox-auth-start')defdropbox_auth_start():authorize_url=get_dropbox_auth_flow(session).start()redirect_to(authorize_url)# URL handler for /dropbox-auth-finish@app.route('/dropbox-auth-finish')defdropbox_auth_finish():try:oauth_result= \get_dropbox_auth_flow(session).finish(request.query_params)exceptBadRequestException,e:http_status(400)    ...

The documentation specified two arguments,web_app_session andrequest, and that's what tripped me originally. With django, only one is needed which is request. With Flask, none is needed.

I think with Django's implementation, implementing for Flask would be clear and straightforward to a newbie.

Hello, is this something you are still interested in working on?

Hello, is this something you are still interested in working on?

Sure@rogebrd. I'll take a look at the failing test

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign ourContributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let usrecheck it.}