Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Integrates text-security npm module to Secrets component#304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
rewanthtammana wants to merge3 commits intodrone:vue
base:vue
Choose a base branch
Loading
fromrewanthtammana:integrate-text-security

Conversation

@rewanthtammana
Copy link

@rewanthtammanarewanthtammana commentedJul 28, 2019•
edited
Loading

Hides the sensitive secret information while typing as password disc symbols to prevent shoulder surfing.

@bradrydzewski@tboerger There were some compilation errors when I tried to include svg, eot and ttf font files. It seems they require updated version of file-loader and url-loader modules. ( Ref:webpack/webpack#6419 ). The latest version of both the modules are added to package.json

Closes#302

cc:@HrushikeshK

@rewanthtammana
Copy link
Author

rewanthtammana commentedAug 2, 2019•
edited
Loading

@tboerger I wasn't familiar with VUE, so I faced issues in importing node_modules. After digging up a bit, I found a new way and its working like a charm. Just removing the "~" did the job perfectly. Please check it.

@rewanthtammana
Copy link
Author

@bradrydzewski@tboerger any changes required for the code? any updates?

Copy link

@tboergertboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would name the classhide-secret, but besides that LGTM

rewanthtammana reacted with laugh emoji
@rewanthtammana
Copy link
Author

I would name the classhide-secret, but besides that LGTM

Done. I was more associated with JS, so just got used to JS coding conventions.

@tboerger
Copy link

cool 👍

rewanthtammana reacted with laugh emoji

@till
Copy link

The change looks great, is anyone merging this soon?

rewanthtammana reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@tboergertboergertboerger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rewanthtammana@tboerger@till
[8]ページ先頭
©2009-2025 Movatter.jp