Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Improve customization#224

Open
Erimus-Koo wants to merge7 commits intodracula:master
base:master
Choose a base branch
Loading
fromErimus-Koo:improve-customization

Conversation

Erimus-Koo
Copy link

I took the liberty of rearranging the code and made a lot of changes at once. I hope these changes are useful and not too difficult to understand.

Because I work as an artist in a gaming company, the changes mainly focus on spacing, color, icons, etc.

image

Rearrange

The previous code may have gone through multiple additions, so after I made changes, the new code I added looked even more messy. So in the end, I adjusted the order of the code and its naming consistency. However, I did not adjust the name of tmux's options to ensure backward compatibility.

The new code follows the following rules.

  • Color Palette
  • Get Tmux Option Variables
    • General
    • For Left Icon
    • For Window
    • For Plugins
  • Left Icon Area
  • Window Area
  • Right Plugins Area

Left Icon Area

  • Add padding & margin
  • Add customized color for prefix status (Previous is )
  • Remove too many if, and standardize the logic for enabling or disabling powerline.
  • status_bg -> variable

Here is my configuration, andall default values that have not been changed.
Left-Icon

Handling of show_powerline

In the previous version, there were manyif statements used to handleshow_powerline.
However, I believe it is simply a marker. Ifshow_powerline is not enabled, changing the marker to blank ("") would suffice. Although there are still several color operations of the blank that need to be handled, it is better than duplicating everything.

Window Area

  • Customize color
  • Customize separator (can invert left sep color)
  • Customize padding & margin
  • Remove the color of flags (follow the fg)
  • The window tab will maintain a consistent width regardless of focus.
    The tab will not suddenly change while you switch between windows.
    (Flags will change the width)

Window

Disable dracula's window settings

If you turn@dracula-window-disabled to true, all the window settings indracula.sh won't be rendered, and.tmux.conf works. You can do some complex things as you wish.

image
  • Index: Window name > folder of the current pane
  • You can also display the number of panes, current program, etc.

Plugins Area

  • Customize each side padding (rightmost separately)
  • Fix the padding of the timezone string.
    If the timezone existed, add one space before the timezone. If not, there's nothing.
    (Prev version always adds an extra space)

Plugins

P.S.

In my daily work, I primarily write Python and front-end projects, and I rarely write Shell scripts. So, I am concerned about making errors and would greatly appreciate a review of my work.

ikhurramraza, JannoTjarks, mamantoha, omeyenburg, and ethancedwards8 reacted with heart emoji
- Add padding & margin- Add customized color for prefix status- Remove too many if, and standardize the logic for enabling or disabling powerline.- status_bg -> variable
- Customize color- Customize separator (can invert left sep color)- Customize padding & margin- Remove color of flags (follow the fg)- The window tab will maintain a consistent width regardless of focus. (Zoom and flags will change the width)
- Customize each side padding (rightmost separately)- Fix the padding of the timezone string
- Add length limit (for integer)- Default align to right (number should align to right, align center makes right padding without control)
@Erimus-Koo
Copy link
Author

And my.tmux.conf

# dracula theme {# general {set -g @dracula-show-powerlinetrue# Enable powerline symbols# separator for leftset -g @dracula-show-left-sep # █     # separator for right symbol (can set any symbol you like as seperator)set -g @dracula-show-right-sep # █     set -g @dracula-border-contrasttrue# pane edge highlightset -g @dracula-status-bg'gray'# }# left icon area {set -g @dracula-show-left-icon'卵#S'# before window #S     🔍  # set -g @dracula-show-left-icon '卵#S #{?window_zoomed_flag, ,}' # before window #S     🔍  set -g @dracula-left-icon-padding-left 1set -g @dracula-left-icon-padding-right 0set -g @dracula-left-icon-margin-right 1set -g @dracula-left-icon-bg'pink'set -g @dracula-left-icon-fg'dark_gray'set -g @dracula-left-icon-prefix-on-bg'red'set -g @dracula-left-icon-prefix-on-fg'white'# }# window area{set -g @dracula-show-flagsfalse# marks of recent windows# inactivty windowset -g @dracula-window-bg'gray'set -g @dracula-window-fg'light_purple'# activty windowset -g @dracula-window-current-bg'green'set -g @dracula-window-current-fg'dark_gray'# paddingset -g @dracula-window-padding-left 0set -g @dracula-window-padding-right 0set -g @dracula-window-margin-right 1# separator mark, set to "" same as the show-sepset -g @dracula-window-left-sep''#    set -g @dracula-window-right-sep''#    set -g @dracula-window-left-sep-invertfalse# use customized window tagset -g @dracula-window-disabledtrue# Dracula Color Pallette{      white='#f8f8f2'      gray='#44475a'      dark_gray='#282a36'      light_purple='#bd93f9'      dark_purple='#6272a4'      cyan='#8be9fd'      green='#50fa7b'      orange='#ffb86c'      red='#ff5555'      pink='#ff79c6'      yellow='#f1fa8c'# }    set-window-option -g window-status-format"\#[fg=${green}]#I:#W#[fg=${dark_purple}]|>\#[fg=${light_purple}]\#{?window_zoomed_flag, ,}\#(pwd=\"#{pane_current_path}\"; echo\${pwd####*/})\"    set-window-option -g window-status-current-format"\#[bg=${gray},fg=${green}]#[bg=${green},fg=${dark_gray}]#I:#W\#[fg=${green},bg=${light_purple}]\#[fg=${yellow}]#{?window_zoomed_flag, ,}\#[fg=${dark_gray}]\#(pwd=\"#{pane_current_path}\"; echo\${pwd####*/})\#[fg=${light_purple},bg=${gray}]"# }# plugins{set -g @dracula-show-empty-pluginsfalse# hide empty plugin# plugins paddingset -g @dracula-plugin-padding-left 0set -g @dracula-plugin-padding-right 1set -g @dracula-plugin-padding-rightmost 1# available plugins: battery, cpu-usage, git, gpu-usage, ram-usage, network, network-bandwidth, network-ping, attached-clients, network-vpn, weather, time, spotify-tui, kubernetes-contextset -g @dracula-plugins"git network-ping ram-usage cpu-usage network-vpn weather battery time"# available colors: white, gray, dark_gray, light_purple, dark_purple, cyan, green, orange, red, pink, yellow# set -g @dracula-[plugin-name]-colors "[background] [foreground]"# gitset -g @dracula-git-colors"orange dark_gray"# networkset -g @dracula-ping-server"baidu.com"set -g @dracula-ping-rate 1set -g @dracula-ping-label""set -g @dracula-network-ping-colors"dark_gray light_purple"# set -g @dracula-network-bandwidth eth0# set -g @dracula-network-bandwidth-interval 0# set -g @dracula-network-bandwidth-show-interface false# ram & cpuset -g @dracula-ram-usage-label""set -g @dracula-ram-usage-colors"cyan gray"set -g @dracula-cpu-usage-label""# set -g @dracula-cpu-display-loadfalse# T:avg load, F:percentset -g @dracula-cpu-usage-colors"red white"# weatherset -g @dracula-show-fahrenheitfalse# use celsius# set -g @dracula-fixed-location "Beijing"set -g @dracula-show-locationfalseset -g @dracula-weather-colors"gray cyan"# batteryset -g @dracula-battery-label""#  set -g @dracula-battery-colors"dark_gray pink"# timeset -g @dracula-time-colors"light_purple dark_gray"set -g @dracula-military-timetrue# 24 hours formatset -g @dracula-show-timezonefalse# hide timezone# }# }

@ethancedwards8
Copy link
Member

This all looks really good. I would like some members of the community to review it, test it, try it out, etc. Does this change anything for users updating? I don't want it to break existing configs.

@Erimus-Koo
Copy link
Author

I think all the user settings have a default value same as the previous version, but I do need more people to test it, there are so many changes. 😂

@rackodo
Copy link

Oh, hey, I can help! I've actually been using Erimus' fork of tmux for about a week now, and I've gotta say that I love the customisability. I'm more than open to provide feedback, if you're interested. :)

@Erimus-Koo
Copy link
Author

Oh, hey, I can help! I've actually been using Erimus' fork of tmux for about a week now, and I've gotta say that I love the customisability. I'm more than open to provide feedback, if you're interested. :)

I'm glad you like it.

Some parts I worry about:

  • I'm not a native English speaker and I don't know if there is a difficult part to understand in naming.
  • As@ethancedwards8 said, Is the configuration backward compatible and will it mess up other users' settings?

@rackodo
Copy link

rackodo commentedJul 11, 2023
edited
Loading

I'm not a native English speaker and I don't know if there is a difficult part to understand in naming.

I didn't find any difficulties in understanding the documentation you put for updating the appearance. It's easy to read and I didn't have any difficulty translating it into my .tmux.conf.

As@ethancedwards8 said, Is the configuration backward compatible and will it mess up other users' settings?

I replaced the original dracula.sh file in.config/tmux/plugins/tmux/scripts with your dracula.sh file and saw no issues pop up. Everything seemed to work completely fine, but that might be different for other users.

Erimus-Koo and ethancedwards8 reacted with thumbs up emoji

@Erimus-Koo
Copy link
Author

That sounds good.

And I found there are some font problems with my.tmux.conf, some glyphs of the mdi icon had been removed. So I updated my.tmux.conf.

And the font I use now isJetBrainsMono Nerd Font v3.0.2
(Prev font is 1.x version JetBrains NF complete.)

My lastest conf 👇🏻
# dracula theme {  # general {    set -g @dracula-show-powerline true  # Enable powerline symbols    # separator for left    set -g @dracula-show-left-sep   # █         # separator for right symbol (can set any symbol you like as seperator)    set -g @dracula-show-right-sep   # █         set -g @dracula-border-contrast true  # pane edge highlight    set -g @dracula-status-bg 'gray'  # }  # left icon area {    set -g @dracula-show-left-icon '󰐝 #S' # before window #S 󰁨  󰄛 󰊠 🔍   󰚌    # set -g @dracula-show-left-icon '󰐝 #S #{?window_zoomed_flag, ,}'    set -g @dracula-left-icon-padding-left 1    set -g @dracula-left-icon-padding-right 0    set -g @dracula-left-icon-margin-right 1    set -g @dracula-left-icon-bg 'pink'    set -g @dracula-left-icon-fg 'dark_gray'    set -g @dracula-left-icon-prefix-on-bg 'red'    set -g @dracula-left-icon-prefix-on-fg 'white'  # }  # window area{    set -g @dracula-show-flags false  # marks of recent windows    # inactivty window    set -g @dracula-window-bg 'gray'    set -g @dracula-window-fg 'light_purple'    # activty window    set -g @dracula-window-current-bg 'green'    set -g @dracula-window-current-fg 'dark_gray'    # padding    set -g @dracula-window-padding-left 0    set -g @dracula-window-padding-right 0    set -g @dracula-window-margin-right 1    # separator mark, set to "" same as the show-sep    set -g @dracula-window-left-sep ''  #        set -g @dracula-window-right-sep ''  #        set -g @dracula-window-left-sep-invert false    # use customized window tag    set -g @dracula-window-disabled true    # Dracula Color Pallette{      dark_gray='#282a36'      gray='#44475a'      white='#f8f8f2'      dark_purple='#6272a4'      cyan='#8be9fd'      green='#50fa7b'      orange='#ffb86c'      pink='#ff79c6'      light_purple='#bd93f9'      red='#ff5555'      yellow='#f1fa8c'      # dark_gray=59      # gray=60      # white=231      # dark_purple=103      # cyan=159      # green=120      # orange=222      # pink=212      # light_purple=183      # red=210      # yellow=229    # }    set-window-option -g window-status-format " \#[fg=${green}]#W#[fg=${dark_purple}] \#[fg=${light_purple}]\#{?window_zoomed_flag, ,}\#(pwd=\"#{pane_current_path}\"; echo \${pwd####*/})\  "    set-window-option -g window-status-current-format "\#[bg=${gray},fg=${green}]#[bg=${green},fg=${dark_gray}]#W\#[fg=${green},bg=${light_purple}] \#[fg=${yellow}]#{?window_zoomed_flag, ,}\#[fg=${dark_gray}]\#(pwd=\"#{pane_current_path}\"; echo \${pwd####*/})\#[fg=${light_purple},bg=${gray}] "  # }  # plugins{    set -g @dracula-show-empty-plugins false    # hide empty plugin    # plugins padding    set -g @dracula-plugin-padding-left 0    set -g @dracula-plugin-padding-right 1    set -g @dracula-plugin-padding-rightmost 1    # available plugins: battery, cpu-usage, git, gpu-usage, ram-usage, network, network-bandwidth, network-ping, attached-clients, network-vpn, weather, time, spotify-tui, kubernetes-context    set -g @dracula-plugins "git network-ping ram-usage cpu-usage network-vpn weather"    # available colors: white, gray, dark_gray, light_purple, dark_purple, cyan, green, orange, red, pink, yellow    # set -g @dracula-[plugin-name]-colors "[background] [foreground]"    # git    set -g @dracula-git-colors "orange dark_gray"    # network    set -g @dracula-ping-server "baidu.com"    set -g @dracula-ping-rate 10    set -g @dracula-ping-label ""    set -g @dracula-network-ping-colors "dark_gray light_purple"    # set -g @dracula-network-bandwidth eth0    # set -g @dracula-network-bandwidth-interval 0    # set -g @dracula-network-bandwidth-show-interface false    # ram & cpu    set -g @dracula-ram-usage-label "󰍛"    set -g @dracula-ram-usage-colors "cyan gray"    set -g @dracula-cpu-usage-label "󰊚"  #      set -g @dracula-cpu-display-load false  # T:avg load, F:percent    set -g @dracula-cpu-usage-colors "red white"    # weather    set -g @dracula-show-fahrenheit false   # use celsius    # set -g @dracula-fixed-location "Beijing"    set -g @dracula-show-location false    set -g @dracula-weather-colors "gray cyan"    # battery    set -g @dracula-battery-label "󰉁"  # 󰉁  󰢝    set -g @dracula-battery-colors "dark_gray pink"    # time    set -g @dracula-time-colors "light_purple dark_gray"    set -g @dracula-military-time true      # 24 hours format    set -g @dracula-show-timezone false     # hide timezone  # }# }

@rackodo
Copy link

I essentially copied your tmux conf but changed the separators and colours.

Here:
# dracula theme {  # general {    set -g @dracula-show-powerline true  # Enable powerline symbols    # separator for left    set -g @dracula-show-left-sep   # █         # separator for right symbol (can set any symbol you like as seperator)    set -g @dracula-show-right-sep   # █         set -g @dracula-border-contrast true  # pane edge highlight    set -g @dracula-status-bg 'gray'  # }  # left icon area {    set -g @dracula-show-left-icon ' #{user}' # before window #S     🔍      # set -g @dracula-show-left-icon '卵#S #{?window_zoomed_flag, ,}' # before window #S     🔍      set -g @dracula-left-icon-padding-left 1    set -g @dracula-left-icon-padding-right 1    set -g @dracula-left-icon-margin-right 0    set -g @dracula-left-icon-bg 'cyan'    set -g @dracula-left-icon-fg 'dark_gray'    set -g @dracula-left-icon-prefix-on-bg 'white'    set -g @dracula-left-icon-prefix-on-fg 'dark_gray'  # }  # window area{    set -g @dracula-show-flags false  # marks of recent windows    # inactivty window    set -g @dracula-window-bg 'gray'    set -g @dracula-window-fg 'light_purple'    # activty window    set -g @dracula-window-current-bg 'green'    set -g @dracula-window-current-fg 'dark_gray'    # padding    set -g @dracula-window-padding-left 0     set -g @dracula-window-padding-right 0    set -g @dracula-window-margin-right 0    # separator mark, set to "" same as the show-sep    set -g @dracula-window-left-sep ''  #        set -g @dracula-window-right-sep ''  #        set -g @dracula-window-left-sep-invert false    # use customized window tag    set -g @dracula-window-disabled true    # Dracula Color Pallette{      white='#f8f8f2'      gray='#44475a'      dark_gray='#282a36'      light_purple='#bd93f9'      dark_purple='#6272a4'      cyan='#8be9fd'      green='#50fa7b'      orange='#ffb86c'      red='#ff5555'      pink='#ff79c6'      yellow='#f1fa8c'    # }    set-window-option -g window-status-format "\  #[fg=${cyan}]#I:#W#[fg=${dark_purple}] \\ \#[fg=${orange}]\#{?window_zoomed_flag, ,}\#(pwd=\"#{pane_current_path}\"; echo \${pwd####*/})\  "    set-window-option -g window-status-current-format "\#[bg=${gray},fg=${cyan}]#[bg=${cyan},fg=${dark_gray}] #I:#W\ #[fg=${cyan},bg=${orange}]\ #[fg=${yellow}]#{?window_zoomed_flag, ,}\#[fg=${dark_gray}]\#(pwd=\"#{pane_current_path}\"; echo \${pwd####*/})\ #[fg=${orange},bg=${gray}]"  # }  # plugins{    set -g @dracula-show-empty-plugins false    # hide empty plugin    # plugins padding    set -g @dracula-plugin-padding-left 1    set -g @dracula-plugin-padding-right 1    set -g @dracula-plugin-padding-rightmost 1    # available plugins: battery, cpu-usage, git, gpu-usage, ram-usage, network, network-bandwidth, network-ping, attached-clients, network-vpn, weather, time, spotify-tui, kubernetes-context    set -g @dracula-plugins "git weather battery time"    # available colors: white, gray, dark_gray, light_purple, dark_purple, cyan, green, orange, red, pink, yellow    # set -g @dracula-[plugin-name]-colors "[background] [foreground]"    # git    set -g @dracula-git-colors "orange dark_gray"    # network    set -g @dracula-ping-server "baidu.com"    set -g @dracula-ping-rate 1    set -g @dracula-ping-label ""    set -g @dracula-network-ping-colors "dark_gray light_purple"    # set -g @dracula-network-bandwidth eth0    # set -g @dracula-network-bandwidth-interval 0    # set -g @dracula-network-bandwidth-show-interface false    # ram & cpu    set -g @dracula-ram-usage-label ""    set -g @dracula-ram-usage-colors "cyan gray"    set -g @dracula-cpu-usage-label ""  #     set -g @dracula-cpu-display-load false  # T:avg load, F:percent    set -g @dracula-cpu-usage-colors "red white"    # weather    set -g @dracula-show-fahrenheit false   # use celsius    # set -g @dracula-fixed-location "Beijing"    set -g @dracula-show-location false    set -g @dracula-weather-colors "gray cyan"    # battery    set -g @dracula-battery-label ""  #      set -g @dracula-battery-colors "dark_gray pink"    # time    set -g @dracula-time-colors "light_purple dark_gray"    set -g @dracula-military-time true      # 24 hours format    set -g @dracula-show-timezone false     # hide timezone  # }# }

If I had to make one request, I wanted to ask if being able to implement an@dracula-show-left-icon-onPrefix would be possible? As in, make it possible to have a different string show when the prefix is activated.

Regardless, this has my vote for being a really big improvement on the original tmux package's customisation. This is impressive work. :)

@Erimus-Koo
Copy link
Author

I've used a plugin(prefix highlight color) that can display the Prefix status, and mode of the window or something.
It can show the Prefix key as string, mine is\``, and most people might be^b^a`.
The length of the string is a little problem of me, that might cause a flick.

In my current version, I use color to know if Prefix activating and you can set the color of it.

And I have an idea, you can set it as the left icon.
It means ifclient_prefix is pressed, show theprefix.

set -g @dracula-show-left-icon'󰐝 #S #{?client_prefix,#{prefix},}'

@Erimus-Koo
Copy link
Author

And I do also wonder where to find all the verbs and names of Tmux.

I can't findclient_prefix intmux(1): terminal multiplexer - Linux man page

I found it in the plugin(prefix highlight color)'s source code.
I'm not sure if you need to install the plugin first.

set -g @plugin 'tmux-plugins/tmux-prefix-highlight'

@PengfeiM
Copy link

does this pr is still wip?
I have been using it for about 3 month, with a cherrypick from main branch which enable a label to show sync status, it works well so far.

@luftaquila
Copy link

I am waiting for this to be merged for the left icon color customization, etc!

PengfeiM and ethancedwards8 reacted with thumbs up emoji

@Erimus-Koo
Copy link
Author

Currently, there are 70 commits behind and 7 other PRs waiting.
Most of my changes are in thescripts/dracula.sh file, which will impact multiple lines.

While reordering the code may not be ideal, I need to add many options. If I don't establish a strong foundation from the start, it could lead to even more confusion later on.

In an open-source project, reorganizing the code is still too difficult. (It may not be necessary.)
In order to enhance code readability, I attempted to divide my previous modifications into separate commits.


In my opinion, the rules below still apply.

The new code follows the following rules.

  • Color Palette
  • Get Tmux Option Variables
  • General
  • For Left Icon
  • For Window
  • For Plugins
  • Left Icon Area
  • Window Area
  • Right Plugins Area

One rule is that the plugins can be sorted alphabetically from A-Z.
Other issues, such as naming, comments, and code style issues, can also be fixed.


It may be better for the owner to reorder the code, and then I can add my code to that version.

@Erimus-Koo
Copy link
Author

I installed the Dracula theme for tmux using the command

set -g @plugin 'dracula/tmux'

However, I think it would be better if the default name of the theme was more specific.

image

@Erimus-Koo
Copy link
Author

Sorry, closed with wrong shortcut.

@ethancedwards8
Copy link
Member

I think I'm going to work on this PR this weekend.

luftaquila and Erimus-Koo reacted with hooray emoji

@ethancedwards8
Copy link
Member

@Erimus-Koo , if you would like to reopen this PR without the structure changes while keeping#296 in mind, I would be happy to merge it.

@Erimus-Koo
Copy link
Author

I've reviewed#296 and it seems reasonable.
Since my modifications took place over a year ago, I need time to review what I changed and assess compatibility with the latest version. I'm willing to make changes, but I can't provide a timeline now.

ethancedwards8 reacted with thumbs up emoji

@Erimus-Koo
Copy link
Author

I started making changes and found some issues. Let's discuss them.

About#296

  • Putting all variables in one place is a good idea.
  • However, usingimport andeval is like Python’simport *, which stops me from seeing all variables before they’re used. This goes against the first point.
  • I’d prefer having all variable names at the start ofdracular.sh, instead of checkingReadme.md. Adding a link to the documentation in `dracular..
  • Also, you can add content besides colors in@dracula-colors, making it too flexible.
  • There are two ways of defining variables: traditional and plain text foreval. This is confusing, removes syntax highlighting, and can lead to input errors.

Structure

  • I tried starting with theleft icon, but hit a snag right away. I want to addmy variables forcolors andspacing, whileexisting variables likeshow_left_icon andshow_left_icon_padding are at the beginning.

    • my variables
      • spacing: padding / margin
      • color: fore/back
      • others: icon/etc.
    • existing variables:show_left_icon andshow_left_icon_padding
  • Because of howdracular.sh is structured, I need to add my color section after line 75,# Handle left icon configuration, since I reference earlier defined colors. Here are a few options:

    1. Addmy variables after line 75.
      The pro is that additions are clear, but someexisting variables for the left icon are elsewhere.
    2. Insertcolor variables after line 75, andspacing variables at the top.
      This way, only necessary parts go after line 75.
    3. Move all left icon-related variables after line 75, includingexisting variables.
      Everything for the left icon is together.

I faced similar issues in the previous PR, which is why I considered adjusting the code structure.

I'm curious,@ethancedwards8, about your thoughts. Which modification would you prefer?

In frontend, CSS often uses sorting rules to organize layout and appearance/color sections.
Spacing, like color, is also crucial. If#296 includes colors, what about spacing or symbols?
I could continue using the traditional method without#296’seval, but I just wanted to express my concerns.
If there are some new changes or rules, maybe I should wait.

@Theoreticallyhugo
Copy link
Collaborator

about your issues with#296:

@dracula-colors is an option that per default is supposed to be doing nothing. hence, for development purposes and default usage, all variables are and stay in one place. any code that is written in dracula should exclusively use the variables defined in dracula.sh at# Dracula Color Pallette.
in other words, the @dracula-colors option should not really change how we write code for dracula/tmux.

there are places in which the color variable is not hard coded, like for all the plugins (usingIFS=' ' read -r -a colors <<< $(get_tmux_option "@dracula-git-colors" "green dark_gray"). in these places, the user can set any color variable to be used, including those added by @dracula-colors. this however doesnt really change anything for those who stay faithful to the built-in dracula color pallette.
i have the hope that, eventually, more places can have their fore and back colors adjusted, like the plugins.

Also, you can add content besides colors in @dracula-colors, making it too flexible.
this is a fair point. as of right now, there are no plans on expanding the functionality of @dracula-colors beyond overriding existing and setting new color variables. users may of course do other shenanigans, but then they are outside of what we are trying to support.

regarding structure

I'm personally not the biggest fan of the giant blob of options in the beginning as theyre kinda hard to navigate. if it was up to me, i would be ok with breaking it up in a sensible way, however id be interested in what@ethancedwards8 thinks about that.

the color for the left icon is set in line 151# Status left. if you want to make the left icons colors customizeable, i would recommend using the aforementionedIFS=' ' read -r -a colors <<< $(get_tmux_option "@dracula-git-colors" "green dark_gray") way in line 151, as it is done throughout the project.

i hope this helps. if you have any questions, please let me know :D

@druxorey
Copy link
Contributor

Is this PR still active? I had not seen it before but it really looks very good like this, I could check to update it with the latest commits to implement it, because I was thinking that there is a lack of customization in the plugin in general.

@Theoreticallyhugo
Copy link
Collaborator

@druxorey
this pr doesnt seem to be active. ethan and i were thinking about implementing improvements like these step by step, so if youd like to work on this, feel free :D

druxorey and ethancedwards8 reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@Erimus-Koo@ethancedwards8@rackodo@PengfeiM@luftaquila@Theoreticallyhugo@druxorey

[8]ページ先頭

©2009-2025 Movatter.jp