- Notifications
You must be signed in to change notification settings - Fork16
Support for async actions#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hey there@neatnerd, really appreciate the contribution! I'm happy to accept async support, but there's a couple things I'd like to see in this PR before I merge it:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(See above comment)
neatnerd commentedJul 25, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Thank you very much for a prompt feedback. Before I proceed - couple of comments/questions:
|
Hi again, You're right that a test probably isn't strictly necessary to check correctness since as you said it is a simple wrapper. But a benefit of writing a test is to make sure this API plays nicely with action creators defined using |
raynor85 commentedSep 20, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I suggest to remove |
Added support for ease of use