Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit2c21516

Browse files
authored
Merge pull request#630 from hrumhurum/gp-fix-b
Memory leak in AppDomain.AssemblyResolve event subscription
2 parentsbf52486 +751e1be commit2c21516

File tree

1 file changed

+26
-18
lines changed

1 file changed

+26
-18
lines changed

‎src/Dotnet.Script.Core/ScriptRunner.cs‎

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -34,30 +34,38 @@ public async Task<TReturn> Execute<TReturn>(string dllPath, IEnumerable<string>
3434
varruntimeDepsMap=ScriptCompiler.CreateScriptDependenciesMap(runtimeDeps);
3535
varassembly=Assembly.LoadFrom(dllPath);// this needs to be called prior to 'AppDomain.CurrentDomain.AssemblyResolve' event handler added
3636

37-
AppDomain.CurrentDomain.AssemblyResolve+=(sender,args)=>ResolveAssembly(args,runtimeDepsMap);
37+
AssemblyOnResolve(objectsender,ResolveEventArgsargs)=>ResolveAssembly(args,runtimeDepsMap);
3838

39-
vartype=assembly.GetType("Submission#0");
40-
varmethod=type.GetMethod("<Factory>",BindingFlags.Static|BindingFlags.Public);
41-
42-
varglobals=newCommandLineScriptGlobals(ScriptConsole.Out,CSharpObjectFormatter.Instance);
43-
foreach(varargincommandLineArgs)
44-
globals.Args.Add(arg);
45-
46-
varsubmissionStates=newobject[2];
47-
submissionStates[0]=globals;
48-
49-
varresultTask=method.Invoke(null,new[]{submissionStates})asTask<TReturn>;
39+
AppDomain.CurrentDomain.AssemblyResolve+=OnResolve;
5040
try
5141
{
52-
_=awaitresultTask;
42+
vartype=assembly.GetType("Submission#0");
43+
varmethod=type.GetMethod("<Factory>",BindingFlags.Static|BindingFlags.Public);
44+
45+
varglobals=newCommandLineScriptGlobals(ScriptConsole.Out,CSharpObjectFormatter.Instance);
46+
foreach(varargincommandLineArgs)
47+
globals.Args.Add(arg);
48+
49+
varsubmissionStates=newobject[2];
50+
submissionStates[0]=globals;
51+
52+
varresultTask=method.Invoke(null,new[]{submissionStates})asTask<TReturn>;
53+
try
54+
{
55+
_=awaitresultTask;
56+
}
57+
catch(System.Exceptionex)
58+
{
59+
ScriptConsole.WriteError(ex.ToString());
60+
thrownewScriptRuntimeException("Script execution resulted in an exception.",ex);
61+
}
62+
63+
returnawaitresultTask;
5364
}
54-
catch(System.Exceptionex)
65+
finally
5566
{
56-
ScriptConsole.WriteError(ex.ToString());
57-
thrownewScriptRuntimeException("Script execution resulted in an exception.",ex);
67+
AppDomain.CurrentDomain.AssemblyResolve-=OnResolve;
5868
}
59-
60-
returnawaitresultTask;
6169
}
6270

6371
publicTask<TReturn>Execute<TReturn>(ScriptContextcontext)

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp