NotificationsYou must be signed in to change notification settings
Fork1.2k
Star7.4k

Migrate to xunit.v3#10890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

Youssef1313 wants to merge7 commits intodotnet:main

base:main

Choose a base branch

fromYoussef1313:xunitv3

Draft

Migrate to xunit.v3#10890

Youssef1313 wants to merge7 commits intodotnet:mainfromYoussef1313:xunitv3

Conversation

Copy link

Member

Youssef1313 commentedMay 28, 2025•
edited
Loading

TODO:

Add dotnet.config

dotnet-policy-servicebot requested review fromdipeshmsft,singhashish-wpf andKuldeep-MS

May 28, 2025 16:14

dotnet-policy-servicebot assignedYoussef1313

May 28, 2025

dotnet-policy-servicebot added PR

metadata: Label to tag PRs, to facilitate with triage

draft labels

May 28, 2025

Copy link

MemberAuthor

Youssef1313 commentedMay 28, 2025

CI fails due to missing package in our feed. Started a mirrorhere

Copy link

MemberAuthor

Youssef1313 commentedMay 28, 2025

/azp run

Copy link

azure-pipelinesbot commentedMay 28, 2025

Azure Pipelines successfully started running 1 pipeline(s).

Youssef1313 force-pushed thexunitv3 branch fromf2e57ba to43487c4Compare

May 28, 2025 17:32

Copy link

MemberAuthor

Youssef1313 commentedMay 28, 2025

Wpf seems to depend onhttps://github.com/dotnet/winforms/blob/main/src/Common/tests/TestUtilities/System.Private.Windows.Core.TestUtilities.csproj. So probably worth moving winforms first

Copy link

MemberAuthor

Youssef1313 commentedJun 14, 2025

winforms moved now withdotnet/winforms#13540

Youssef1313 force-pushed thexunitv3 branch from8a2d5a7 to3c31dd9Compare

June 14, 2025 04:18

Youssef1313 added2 commits

June 16, 2025 15:22

Migrate to xunit.v3

89be83f

Update

1a898fc

Youssef1313 force-pushed thexunitv3 branch from8a4ded7 to1a898fcCompare

June 16, 2025 13:22

Youssef1313 added2 commits

June 16, 2025 15:54

Fix

ecd1950

Fix

80e6cb4

Copy link

MemberAuthor

Youssef1313 commentedJun 16, 2025

=== COMMAND LINE === "D:\a\_work\1\s\artifacts\bin\System.Xaml.Tests\x64\Debug\net10.0\System.Xaml.Tests.exe"    --hangdump --hangdump-timeout 10min --crashdump --results-directory "D:\a\_work\1\s\artifacts\TestResults\Debug" --report-xunit --report-xunit-filename "System.Xaml.Tests_net10.0_x64.xml" --report-xunit-html --report-xunit-html-filename "System.Xaml.Tests_net10.0_x64.html" --report-trx --report-trx-filename "System.Xaml.Tests_net10.0_x64.trx" --auto-reporters off [createdump] Writing full dump for process 3616 to file D:\a\_work\1\s\artifacts\TestResults\Debug\System.Xaml.Tests_3616_crash.dmp[createdump] Dump successfully written in 2905ms[+0/x0/?0] System.Xaml.Tests.dll (net10.0|x64)(3s)Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'typeName')   at System.ArgumentNullException.Throw(String paramName)   at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)   at System.ComponentModel.TypeConverterAttribute..ctor(String typeName)   at System.Reflection.CustomAttribute.CreateCustomAttributeInstance(RuntimeModule module, RuntimeType type, IRuntimeMethodInfo ctor, IntPtr& blob, IntPtr blobEnd, Int32& namedArgs)   at System.Reflection.CustomAttribute.AddCustomAttributes(ListBuilder`1& attributes, RuntimeModule decoratedModule, Int32 decoratedMetadataToken, RuntimeType attributeFilterType, Boolean mustBeInheritable, ListBuilder`1 derivedAttributes)   at System.Reflection.CustomAttribute.GetCustomAttributes(RuntimeType type, RuntimeType caType, Boolean inherit)   at System.Attribute.GetCustomAttributes(MemberInfo element, Boolean inherit)   at Xunit.Sdk.ReflectionExtensions.GetMatchingCustomAttributes(Type type, Type attributeType) in /_/src/xunit.v3.common/Extensions/ReflectionExtensions.cs:line 234   at Xunit.v3.TestCollectionFactoryBase.Get(Type testClass) in /_/src/xunit.v3.core/Framework/TestCollectionFactoryBase.cs:line 37   at Xunit.v3.XunitTestFrameworkDiscoverer.CreateTestClass(Type class) in /_/src/xunit.v3.core/Framework/XunitTestFrameworkDiscoverer.cs:line 58   at Xunit.v3.TestFrameworkDiscoverer`1.<>c__DisplayClass10_0.<<Find>b__0>d.MoveNext() in /_/src/xunit.v3.core/Framework/TestFrameworkDiscoverer.cs:line 76--- End of stack trace from previous location ---   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__124_1(Object state)   at System.Threading.QueueUserWorkItemCallback.Execute()   at System.Threading.ThreadPoolWorkQueue.Dispatch()   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()   at System.Threading.Thread.StartCallback()Test host process with PID '3616' crashed, a dump file was generatedTest application process didn't exit gracefully, exit code is '7'

cc@bradwilson

Copy link

bradwilson commentedJun 16, 2025

Hard to tell but this looks like a custom attribute might be throwing in a constructor somewhere...?

Copy link

bradwilson commentedJun 16, 2025

I'd be curious to know what happens if you try using3.0.0-pre.25 because I just removed calls toGetCustomAttributes to help ignore attributes that are throwing in their constructors.

Update to 3.0.0-pre.25

1c57c99

Copy link

MemberAuthor

Youssef1313 commentedJun 18, 2025•
edited
Loading

Updating helped. There are other failures that I'm investigating now.

@bradwilson I'm curious whether you're planning to ship xunit.v3 3.x stable going to be released some time soon?

Copy link

bradwilson commentedJun 18, 2025

Right now, our release plan is to allow third parties chances to find issues with breaking changes, we will give them a month to review the changes.

The most recent build shipped 3 days ago. Assuming there are no further builds that need to be shipped to account for new breaking changes (and thus reset the clock), then a final release should be in the middle of July.