- Notifications
You must be signed in to change notification settings - Fork1.2k
Avoid boxing booleans during tracing and when settingbool? properties#10884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
h3xds1nz wants to merge4 commits intodotnet:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
codecovbot commentedMay 26, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #10884 +/- ##===================================================- Coverage 13.48885% 2.98817% -10.50068%=================================================== Files 3317 3319 +2 Lines 664749 664888 +139 Branches 74643 74674 +31 ===================================================- Hits 89667 19868 -69799- Misses 572488 644839 +72351+ Partials 2594 181 -2413
Flags with carried forward coverage won't be shown.Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Community ContributionA label for all community Contributions draftPRmetadata: Label to tag PRs, to facilitate with triage
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This should be only merged after#10711 so we don't have to unnecessarily add the usings for
KnownBoxes.Gonna draft it for the same reason so that I can do an additional sweep once it is merged.
Description
Avoids boxing booleans in a few more cases than already done in#10628 and#10711.
I didn't opt-in for making a
nullable<bool>helper for DPs as its not that prevalent and saves a few bytes.Customer Impact
Less boxed booleans on the heap, less memory usage.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers:Open in CodeFlow