- Notifications
You must be signed in to change notification settings - Fork1.2k
Remove non-CLS exceptions handlers and CS1058 suppressions (+ cleanup)#10876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
h3xds1nz wants to merge2 commits intodotnet:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
34 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
Community ContributionA label for all community Contributions draftPRmetadata: Label to tag PRs, to facilitate with triage
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This is blocked by#10874 /#10875, hence draft.
Description
Removes non-CLS exceptions handlers (general catch handler blocks) in
LineServicesCallbacksthat are never executed (basically a dead-code). This originates from pre-NetFXv2/C# 2.0behaviour before non-CLS exceptions were being wrapped by default asRuntimeWrappedExceptionwhich derives fromExceptionand hence you needed a generalcatchhandler.Nowadays Roslyn emits
[assembly: RuntimeCompatibility(WrapNonExceptionThrows = true)]by default so all non-CLS exceptions are already handled viacatch (Exception e)blocks and never fallthrough to the generalcatch { }handler.Customer Impact
Smaller assembly size, codegen size and cleaner codebase for developers.
Regression
No.
Testing
Local build.
Risk
Low, those would be generally caught by CS1058 but the warning was suppressed. Reviewers just need to make sure the removed blocks are preceeded by
catch (Exception e)to achieve the same effect.Microsoft Reviewers:Open in CodeFlow