- Notifications
You must be signed in to change notification settings - Fork1.1k
Fix Win32Exception when clicking ToolBar Options after narrowing form width#14104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
Copilot wants to merge3 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+54 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… widthWhen a ToolStripControlHost item (like ToolStripComboBox or ToolStripProgressBar) movesto the overflow dropdown, the hosted control should remain parented to the Owner ToolStrip,not the dropdown. ToolStripDropDown is a TopLevel popup window, and parenting controls toit can cause Win32Exception due to SetParent failures (e.g., DPI awareness mismatches).Fixes#14077Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Clarify why parenting controls to ToolStripDropDown causes Win32Exception(DPI awareness mismatches or window hierarchy constraints)Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
CopilotAI changed the title[WIP] Fix Win32Exception on ToolStrip options click after form width reductionFix Win32Exception when clicking ToolBar Options after narrowing form widthDec 4, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#14094
Proposed changes
ToolStripControlHost.SyncControlParent()to keep hosted controls parented toOwnerToolStrip whenParentInternalis aToolStripDropDownRoot cause: When
ToolStripControlHostitems (e.g.,ToolStripComboBox,ToolStripProgressBar) move to overflow,SyncControlParent()was adding the hosted control to theToolStripOverflow's Controls collection. When the dropdown shows,CreateControlcallsSetParentHandlewhich fails becauseToolStripDropDownis a TopLevel popup window (DPI awareness/window hierarchy constraints).Customer Impact
Win32Exceptioncrashes app when clicking overflow button on narrowed ToolStrip containing control hostsToolStripComboBoxorToolStripProgressBarin constrained layoutsRegression?
Risk
ToolStripControlHostparenting when parent is a dropdownTest methodology
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
0t3vsblobprodcus362.vsblob.vsassets.io/usr/bin/dotnet dotnet restore(dns block)o3svsblobprodcus318.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/winforms/winforms/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/winforms/winforms/artifacts/toolset/11.0.0-beta.25602.105.txt rivate.Windows.Core/src/System/V--property=CPUQuota=5% rivate.Windows.Core/src/System/P--property=MemoryHigh=170M rivate.Windows.Ccurl rivate.Windows.C--retry rivate.Windows.C20 rivate.Windows.C--retry-delay(dns block)/usr/bin/dotnet dotnet restore(dns block)/usr/bin/dotnet dotnet build --no-restore(dns block)rcxvsblobprodcus328.vsblob.vsassets.io/usr/bin/dotnet dotnet build --no-restore(dns block)vwvvsblobprodcus334.vsblob.vsassets.io/usr/bin/dotnet dotnet restore(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn moreCopilot coding agent tips in the docs.
Microsoft Reviewers:Open in CodeFlow