dotnet/vscode-csharpPublic

NotificationsYou must be signed in to change notification settings
Fork714
Star3k

Adding changes to support use monovsdbg to debug wasm apps.#7220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

thaystg wants to merge19 commits intodotnet:main

base:main

Choose a base branch

fromthaystg:dev/thays/support_wasm_monovsdbg

Draft

Adding changes to support use monovsdbg to debug wasm apps.#7220

thaystg wants to merge19 commits intodotnet:mainfromthaystg:dev/thays/support_wasm_monovsdbg

Conversation

Copy link

Member

thaystg commentedJun 10, 2024•
edited
Loading

Adding changes to support debug wasm apps using monovsdbg.

Tested scenarios with the new setting enabled and this PR:

With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Wasm) -DISABLED
With Assets and C# DevKit Not Installed targetting .NET 8 (Blazor Server Wasm) -DISABLED
With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Wasm) -ENABLED
With Assets and C# DevKit Not Installed targetting .NET 9 (Blazor Server Wasm) -ENABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) -DISABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) -DISABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) -ENABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) -ENABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) -DISABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) -DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) -ENABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) -ENABLED

Tested scenarios only updating C# DevKit with the monovsdbg support:

Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 8 (Blazor Wasm) -DISABLED
Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 8 (Blazor Server Wasm) -DISABLED
Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 9 (Blazor Wasm) -DISABLED
Without Assets and C# DevKit Installed with C# extension without this PR targetting .NET 9 (Blazor Server Wasm) -DISABLED

Tested scenarios with this PR and C# DevKit without the monovsdbg support:

With Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) -DISABLED
With Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) -DISABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) -ENABLED
With Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) -ENABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Wasm) -DISABLED
Without Assets and C# DevKit Installed targetting .NET 8 (Blazor Server Wasm) -DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Wasm) -DISABLED
Without Assets and C# DevKit Installed targetting .NET 9 (Blazor Server Wasm) -DISABLED

Adding changes to support use monovsdbg to debug wasm apps.

1f4d94e

gregg-miskelly reviewed

Jun 10, 2024

View reviewed changes

package.json OutdatedShow resolvedHide resolved

gregg-miskelly reviewed

Jun 10, 2024

View reviewed changes

package.nls.json OutdatedShow resolvedHide resolved

gregg-miskelly reviewed

Jun 10, 2024

View reviewed changes

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts OutdatedShow resolvedHide resolved

gregg-miskelly reviewed

Jun 10, 2024

View reviewed changes

src/shared/utils.ts Outdated

		@@ -43,6 +43,14 @@ export function isWebProject(projectPath: string): boolean {
		return projectFileText.toLowerCase().indexOf('sdk="microsoft.net.sdk.web"') >= 0;
		}

		export function isWebAssemblyProject(projectPath: string): boolean {
		const projectFileText = fs.readFileSync(projectPath, 'utf8');

Copy link

Contributor

gregg-miskellyJun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

const projectFileText = fs.readFileSync(projectPath, 'utf8');

Instead of reading the file a second time, I would suggest changingisWebProject togetProjectFlags and returning both.

Copy link

MemberAuthor

thaystgJun 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

done

gregg-miskelly reviewed

Jun 10, 2024

View reviewed changes

src/shared/assets.tsShow resolvedHide resolved

thaystg added11 commits

June 13, 2024 12:11

Adding VSWebAssemblyPackage.

d7f8606

Addressing Gregg's comments

cfb2d67

Fixing prettier

d59699b

Fixing package.json

981c74b

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

0bc4ca2

Adding vswebassembly to gitignore

c4d88dc

Test if the vswebassembly path exists and also pass DOTNET_MODIFIABLE…

d3b8441

…_ASSEMBLIES to enable hotreload.

Fix prettier

b094acf

Bump VSWebAssemblyBridge.

4796772

Check targetFramework before enable it.

83de7bb

Merge branch 'dev/thays/support_wasm_monovsdbg' of github.com:thaystg…

e2802c1

…/vscode-csharp into dev/thays/support_wasm_monovsdbg

thaystg marked this pull request as ready for review

June 22, 2024 00:38

thaystg requested review froma team ascode owners

June 22, 2024 00:38

thaystg requested a review fromgregg-miskelly

June 22, 2024 00:52

Copy link

MemberAuthor

thaystg commentedJun 28, 2024

@gregg-miskelly can you please review again?
I think I addressed all your comments.

gregg-miskelly requested changes

Jun 28, 2024

View reviewed changes

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts OutdatedShow resolvedHide resolved

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.tsShow resolvedHide resolved

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts OutdatedShow resolvedHide resolved

src/shared/assets.ts OutdatedShow resolvedHide resolved

src/shared/utils.ts OutdatedShow resolvedHide resolved

thaystg added3 commits

July 1, 2024 20:03

Addressing Gregg's comments.

d6fd0b6

Renaming function.

04b4c77

Addressing Gregg's comments.

a5452a8

thaystg requested a review fromgregg-miskelly

July 2, 2024 15:28

thaystg added3 commits

July 2, 2024 13:48

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

2b1ee0d

Addressing Gregg's comments.

e06f914

Merge branch 'main' into dev/thays/support_wasm_monovsdbg

4e70917

Copy link

MemberAuthor

thaystg commentedJul 8, 2024•
edited
Loading

@gregg-miskelly I think I'm done again. If you can review it will be great.

gregg-miskelly reviewed

Jul 8, 2024

View reviewed changes

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts OutdatedShow resolvedHide resolved

gregg-miskelly reviewed

Jul 8, 2024

View reviewed changes

src/razor/src/blazorDebug/blazorDebugConfigurationProvider.ts OutdatedShow resolvedHide resolved

gregg-miskelly approved these changes

Jul 8, 2024

View reviewed changes

Copy link

Contributor

gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Otherwise LGTM

Addressing Gregg's suggestion.

9dfa93c

gregg-miskelly approved these changes

Jul 11, 2024

View reviewed changes

Copy link

Contributor

WardenGnaw commentedJul 15, 2024

Did you want to update a case for the updatePackageDependencies script?

vscode-csharp/src/tools/updatePackageDependencies.ts

Line 276 in602cd79

}else{

Copy link

MemberAuthor

thaystg commentedJul 16, 2024

Did you want to update a case for the updatePackageDependencies script?
vscode-csharp/src/tools/updatePackageDependencies.ts
Line 276 in602cd79
}else{

I'm using npm run updatePackageDependencies to update the webassembly package but I didn't need to change this file.

Copy link

Member

JoeRobich commentedFeb 6, 2025

@thaystg Is this still a change we want to consider?

Copy link

MemberAuthor

thaystg commentedFeb 7, 2025

Correct, we will work on it yet, but I will mark it as a draft for now.

thaystg marked this pull request as draft

February 7, 2025 13:39

Labels

None yet

4 participants

Movatterモバイル変換

Adding changes to support use monovsdbg to debug wasm apps.#7220

Are you sure you want to change the base?

Adding changes to support use monovsdbg to debug wasm apps.#7220

Uh oh!

Conversation

thaystg commentedJun 10, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregg-miskellyJun 10, 2024

Choose a reason for hiding this comment

Uh oh!

thaystgJun 19, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

thaystg commentedJun 28, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thaystg commentedJul 8, 2024• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gregg-miskelly left a comment

Choose a reason for hiding this comment

Uh oh!

WardenGnaw commentedJul 15, 2024

Uh oh!

thaystg commentedJul 16, 2024

Uh oh!

JoeRobich commentedFeb 6, 2025

Uh oh!

thaystg commentedFeb 7, 2025

Uh oh!

Uh oh!

thaystg commentedJun 10, 2024•
edited
Loading

thaystg commentedJul 8, 2024•
edited
Loading