Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | Align TdsExecuteRPC between netcore and netfx#3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

benrr101
Copy link
Contributor

Recreation of#2985 to resolve merge conflicts and get full CI runs

Splitting up TdsExecuteRPC to multiple functions to align netcore and netfx

Part of#2953

@benrr101benrr101 added this to the6.1-preview1 milestoneApr 22, 2025
@benrr101benrr101 requested a review froma teamApril 22, 2025 22:52
…t/TdsParser.csSimplify a if statement where they're the same regardless of true/falseCo-authored-by: Edward Neal <55035479+edwardneal@users.noreply.github.com>
@codecovCodecov
Copy link

codecovbot commentedApr 23, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is83.33333% with36 lines in your changes missing coverage. Please review.

Project coverage is 73.03%. Comparing base(c5e3c40) to head(22b0f8e).
Report is 16 commits behind head on main.

Files with missing linesPatch %Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs83.33%36 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3292      +/-   ##==========================================+ Coverage   72.98%   73.03%   +0.04%==========================================  Files         299      298       -1       Lines       57215    57033     -182     ==========================================- Hits        41760    41653     -107+ Misses      15455    15380      -75
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.35% <ø> (+0.15%)⬆️
netfx71.51% <83.33%> (+0.02%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101 merged commit98b2c84 intomainApr 29, 2025
251 checks passed
@benrr101benrr101 deleted the dev/russellben/mz-merge-tdsparser-tdsexecuterpc branchApril 29, 2025 21:04
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Wraith2Wraith2Wraith2 left review comments

@edwardnealedwardnealedwardneal left review comments

@apoorvdeshmukhapoorvdeshmukhapoorvdeshmukh approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

@samsharma2700samsharma2700samsharma2700 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

7 participants
@benrr101@apoorvdeshmukh@Wraith2@cheenamalhotra@edwardneal@samsharma2700@MichelZ
[8]ページ先頭
©2009-2025 Movatter.jp