NotificationsYou must be signed in to change notification settings
Fork311
Star927

Remove ADP.IsEmpty()#3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

cheenamalhotra merged 1 commit intodotnet:mainfromErikEJ:remove-adp-isempty

Apr 16, 2025

Merged

Remove ADP.IsEmpty()#3277

cheenamalhotra merged 1 commit intodotnet:mainfromErikEJ:remove-adp-isempty

Apr 16, 2025

Conversation

Copy link

Contributor

ErikEJ commentedApr 15, 2025

No description provided.

Remove ADP.IsEmpty()

ad0b284

samsharma2700 self-assigned this

Apr 15, 2025

Copy link

ContributorAuthor

ErikEJ commentedApr 15, 2025

@samsharma2700 @mdaigle Could some start the CI?

Copy link

Contributor

mdaigle commentedApr 15, 2025

/azp run

Copy link

azure-pipelinesbot commentedApr 15, 2025

Azure Pipelines successfully started running 1 pipeline(s).

paulmedynski approved these changes

Apr 16, 2025

View reviewed changes

Copy link

Contributor

paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Removing stuff like this is very satisfying :)

paulmedynski requested a review froma team

April 16, 2025 10:54

paulmedynski self-assigned this

Apr 16, 2025

apoorvdeshmukh approved these changes

Apr 16, 2025

View reviewed changes

Copy link

Contributor

apoorvdeshmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

cheenamalhotra added this to the6.1-preview1 milestone

Apr 16, 2025

cheenamalhotra approved these changes

Apr 16, 2025

View reviewed changes

cheenamalhotra merged commitc5e3c40 intodotnet:main

Apr 16, 2025

122 checks passed

Copy link

codecovbot commentedApr 16, 2025

Codecov Report

Attention: Patch coverage is73.46939% with13 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base(aa35edc) to head(ad0b284).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...x/src/Microsoft/Data/SqlClient/SqlDataReaderSmi.cs	0.00%	6 Missing⚠️
...fx/src/Microsoft/Data/Common/DBConnectionString.cs	25.00%	3 Missing⚠️
...x/src/Microsoft/Data/Common/DbConnectionOptions.cs	80.00%	1 Missing⚠️
...rc/Microsoft/Data/SqlClient/SqlClientPermission.cs	0.00%	1 Missing⚠️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs	87.50%	1 Missing⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	0.00%	1 Missing⚠️

❗ There is a different number of reports uploaded between BASE (aa35edc) and HEAD (ad0b284). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (aa35edc) HEAD (ad0b284)
addons 1 0

Additional details and impacted files

@@            Coverage Diff             @@##             main    #3277      +/-   ##==========================================- Coverage   72.91%   66.26%   -6.66%==========================================  Files         296      289       -7       Lines       57257    56901     -356     ==========================================- Hits        41751    37704    -4047- Misses      15506    19197    +3691