Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | SqlDataReader#3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdaigle merged 3 commits intodotnet:mainfromedwardneal:merge/sqldatareader
Apr 10, 2025
Merged

Conversation

edwardneal
Copy link
Contributor

Fixes#2965.
Contributes to#1261.

This merges SqlDataReader. It might be worth reviewing each commit individually:

  • Commit 1 merges the contents of the files.
  • Commit 2 replaces the files and patches the XML documentation paths.
  • Commit 3 mops up two debug assertions and a comment.

Could someone run CI please?

@samsharma2700samsharma2700 self-assigned thisApr 8, 2025
@samsharma2700samsharma2700 requested a review froma teamApril 8, 2025 17:44
@paulmedynskipaulmedynski self-assigned thisApr 8, 2025
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101benrr101 added the Common Project 🚮Things that relate to the common project project labelApr 8, 2025
@benrr101benrr101 self-assigned thisApr 8, 2025
@codecovCodecov
Copy link

codecovbot commentedApr 8, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is78.57143% with3 lines in your changes missing coverage. Please review.

Project coverage is 66.19%. Comparing base(1690e02) to head(e83f966).
Report is 5 commits behind head on main.

Files with missing linesPatch %Lines
...ient/src/Microsoft/Data/SqlClient/SqlDataReader.cs50.00%3 Missing⚠️

❗ There is a different number of reports uploaded between BASE (1690e02) and HEAD (e83f966). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (1690e02)HEAD (e83f966)
addons10
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3259      +/-   ##==========================================- Coverage   72.83%   66.19%   -6.64%==========================================  Files         298      290       -8       Lines       59675    56944    -2731     ==========================================- Hits        43463    37693    -5770- Misses      16212    19251    +3039
FlagCoverage Δ
addons?
netcore68.95% <50.00%> (-6.30%)⬇️
netfx65.17% <78.57%> (-6.29%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaiglemdaigle added this to the6.1-preview1 milestoneApr 10, 2025
@mdaiglemdaigle merged commit89d5b8c intodotnet:mainApr 10, 2025
122 checks passed
@edwardnealedwardneal deleted the merge/sqldatareader branchApril 10, 2025 19:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Labels
Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

Work towards merging SqlDataReader
5 participants
@edwardneal@paulmedynski@mdaigle@benrr101@samsharma2700
[8]ページ先頭
©2009-2025 Movatter.jp