Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | Port PR 499 to .NET Framework#3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 1 commit intodotnet:mainfromedwardneal:merge/port-pr499
Apr 7, 2025

Conversation

edwardneal
Copy link
Contributor

@edwardnealedwardneal commentedApr 2, 2025•
edited
Loading

This ports#499 from netcore to netfx.

Relates to#1261.
Relates to#2965.

Once this PR is finished, the next PR which touches SqlDataReader will be able to merge it.

I'd appreciate a CI run of this please.

@edwardnealedwardneal changed the titlePort PR 499 to .NET FrameworkMerge | Port PR 499 to .NET FrameworkApr 2, 2025
@cheenamalhotra
Copy link
Member

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecovCodecov
Copy link

codecovbot commentedApr 3, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is88.00000% with3 lines in your changes missing coverage. Please review.

Project coverage is 66.30%. Comparing base(1247ca4) to head(b132943).
Report is 14 commits behind head on main.

Files with missing linesPatch %Lines
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs88.00%3 Missing⚠️

❗ There is a different number of reports uploaded between BASE (1247ca4) and HEAD (b132943). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (1247ca4)HEAD (b132943)
addons10
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3255      +/-   ##==========================================- Coverage   72.69%   66.30%   -6.39%==========================================  Files         303      292      -11       Lines       59718    59324     -394     ==========================================- Hits        43414    39337    -4077- Misses      16304    19987    +3683
FlagCoverage Δ
addons?
netcore69.02% <ø> (-6.09%)⬇️
netfx65.23% <88.00%> (-6.15%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mdaiglemdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like basically a 1:1 port and tests pass ✔️

@mdaiglemdaigle self-assigned thisApr 3, 2025
@benrr101benrr101 merged commit1690e02 intodotnet:mainApr 7, 2025
123 checks passed
@edwardnealedwardneal deleted the merge/port-pr499 branchApril 7, 2025 18:45
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@mdaiglemdaiglemdaigle approved these changes

Assignees

@mdaiglemdaigle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@edwardneal@cheenamalhotra@benrr101@mdaigle
[8]ページ先頭
©2009-2025 Movatter.jp