Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Tidy up performance tests#3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
paulmedynski merged 2 commits intomainfromdev/paul/performance-tidy
Mar 24, 2025
Merged

Conversation

paulmedynski
Copy link
Contributor

  • Tidied up the existing Performance benchmarks.
  • Added environment variables to specify config files.
  • Removed Newtonsoft.Json as a dependency.
  • Simplified csproj a bit.

- Tidied up the existing Performance benchmarks.- Added environment variables to specify config files.- Removed Newtonsoft.Json as a dependency.- Simplified csproj a bit.
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR tidies up the performance tests by refactoring configuration loading, removing the Newtonsoft.Json dependency, and simplifying project files.

  • Introduces a new JSON configuration loader using System.Text.Json.
  • Updates performance test configuration for benchmarks and data types across several files.
  • Revises the BUILDGUIDE to include instructions for setting up the runner configuration and an empty database.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Loader.csAdds a utility to load JSON configs with environment variable overrides.
BUILDGUIDE.mdUpdates usage instructions for benchmarks and configuration management.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/DataTypes.csIntroduces a Load() method to load data types configuration.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Config/Config.csAdds a Load() method for benchmark configuration.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/Program.csRefactors config loading and benchmark execution from a static context to an instance context.
src/Microsoft.Data.SqlClient/tests/PerformanceTests/BenchmarkRunners/BaseRunner.csReplaces Newtonsoft.Json deserialization with the new Loader API.
Files not reviewed (2)
  • src/Microsoft.Data.SqlClient/tests/PerformanceTests/Microsoft.Data.SqlClient.PerformanceTests.csproj: Language not supported
  • tools/props/Versions.props: Language not supported

@paulmedynskipaulmedynski requested a review froma teamMarch 19, 2025 17:19
@paulmedynskipaulmedynski marked this pull request as ready for reviewMarch 19, 2025 17:20
@paulmedynskipaulmedynski added this to the7.0-preview1 milestoneMar 19, 2025
@codecovCodecov
Copy link

codecovbot commentedMar 19, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.92%. Comparing base(f3ae72a) to head(55938e5).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3230      +/-   ##==========================================+ Coverage   72.73%   72.92%   +0.18%==========================================  Files         288      303      +15       Lines       59527    59527              ==========================================+ Hits        43298    43409     +111+ Misses      16229    16118     -111
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.33% <ø> (+0.14%)⬆️
netfx71.51% <ø> (+0.13%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Improved benchmark running instructions.
@paulmedynskipaulmedynski requested a review froma teamMarch 20, 2025 11:50
@paulmedynskipaulmedynski merged commit04b0a8d intomainMar 24, 2025
252 checks passed
@paulmedynskipaulmedynski deleted the dev/paul/performance-tidy branchMarch 24, 2025 11:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ErikEJErikEJErikEJ left review comments

Copilot code reviewCopilotCopilot left review comments

@mdaiglemdaiglemdaigle approved these changes

@samsharma2700samsharma2700samsharma2700 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

4 participants
@paulmedynski@ErikEJ@mdaigle@samsharma2700
[8]ページ先頭
©2009-2025 Movatter.jp